From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id B26D7384514B for ; Wed, 5 Jun 2024 17:12:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B26D7384514B Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B26D7384514B Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1717607581; cv=none; b=kcGg1gHZ3WvpQKnaLJUie0J0YR2QvIVVFf6AI3gZ1+d70kbuON7ykJp/UkiDs0tsy58skx1vmX7Nc+/uyda2YUoRHHNl0nh/BaSA41D3A5wZsHcOF5UTbk5kb/ad9YvkhDELgsblFN5KQdRVgyq9gUEEUg4mspmHWGwYk6MY3Rk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1717607581; c=relaxed/simple; bh=Gpc2kdvnmOPrfbUxQX01jhPIPWcA52uEzQwJP84OLMA=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=li5Y7+sUH0eDUfz7Feuu/zsijh5Tv0wpcIqn9eVFCP9OFsm+napLkKq932La6tdsgYPDI5rUaBugyWg0ZA5Tnzg0xcBvPkauzp9o3ypoiLy6+5U+1hXv+p/y4i4Ue04F7URqW0c2S6IWi8UJ2gSc3QFLhn195F3D/RaGPl3CqEY= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1717607571; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=oZUYIm39uuNw54VGQkpa4XsYsMN9dLxoPMhSzm8lDtg=; b=Ef7eCL5olNTfmWksjWZXE+oauvT0gTozFv7f4Wo0Vox5/AdID268vcW5hNTOXoD5NCmGIt SBTl4PRj0jcuhcbpKR0TOoUHAvdezkyh+YdQvm0RGFUvsnhUQ7LFrJwZcV7AGoeDvSSmKt vvigZTKxfVhc82cEIWbJEgV4Z6mx8F0= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-42-wS3LxgtmMZG8vJ_tp62VRw-1; Wed, 05 Jun 2024 13:12:49 -0400 X-MC-Unique: wS3LxgtmMZG8vJ_tp62VRw-1 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-35e50fe93a5so159902f8f.3 for ; Wed, 05 Jun 2024 10:12:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717607568; x=1718212368; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=oZUYIm39uuNw54VGQkpa4XsYsMN9dLxoPMhSzm8lDtg=; b=qcmWwgzevtvmTvWsTSEzFMVjf6EWV+bPRigNyeeI0UUim5+byZhzESSyP/ZGEIVbFM KYRxGPFRFnixDJV0IdGWgmenIQvmsMay0KT8WmvhxvJBD2/yWgwYaH8oL8xM2+vAvYgh Tf5h9PoUw+/dVpEtJ7mRnbjtnPegkcAEwHJ7uDU7LRfIT8mw1Hqc5NiRRTY5uPvGuHwG vOVVmWKQ5e6BkAuxUoka7lsSPwQd3V9IOcn0x9tsBauH6SZDft9bE7ZlYmu/eOzSSOYV hYx51EmYXlKpO/Lq42NEPfJsR62b31KF70fF9qybj0LCrR0lEhxP3/GLMnHY6DKMOC+8 k5yQ== X-Forwarded-Encrypted: i=1; AJvYcCVhhYrzELaHx/vzTCWb7CSibS7ajte9mXSjsVv8oqE+uVZaHJAnVp33UKHHXsWD/TlrMuixbrb+wlBpFqNEodlCfQrtqKiCc9EsJQ== X-Gm-Message-State: AOJu0Yz/Yg5whwo5gqhGmUNJ4X0U11sOY84gdWfDD4XSVXTEbG6hkpFP u1U5hRIN6F6TZKEbqpGjPIoKutFUACf3teZnG8+hq1ZSgmJx9vAD201TDskiQP+l+oxK9MnH7a9 HTiOt8QW7tClBN5Hef/rve63BgI5tN0ccFR8eP6ULZCW3k6NVk84Gm1rdd3g= X-Received: by 2002:a05:6000:1568:b0:356:49a8:7e12 with SMTP id ffacd0b85a97d-35e8404942emr3317565f8f.9.1717607568465; Wed, 05 Jun 2024 10:12:48 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF2DHXyzq7Z3THNwawhO9swy9AOwwWQzAk0ofVBKdoA4BDVugxsq81L/LXsJijPcQWPdY+wSA== X-Received: by 2002:a05:6000:1568:b0:356:49a8:7e12 with SMTP id ffacd0b85a97d-35e8404942emr3317539f8f.9.1717607567942; Wed, 05 Jun 2024 10:12:47 -0700 (PDT) Received: from localhost ([31.111.84.186]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-35dd062ea66sm15191587f8f.78.2024.06.05.10.12.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Jun 2024 10:12:47 -0700 (PDT) From: Andrew Burgess To: "Willgerodt, Felix" , "gdb-patches@sourceware.org" Cc: "jhb@FreeBSD.org" Subject: RE: [PATCHv7 8/9] gdbserver: update target description creation for x86/linux In-Reply-To: References: <40f37b5589e9e440d9bf8fdf51f65fde653e55d3.1715421687.git.aburgess@redhat.com> Date: Wed, 05 Jun 2024 18:12:47 +0100 Message-ID: <87le3jb9f4.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-11.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: "Willgerodt, Felix" writes: >> diff --git a/gdbserver/linux-amd64-ipa.cc b/gdbserver/linux-amd64-ipa.cc >> index df5e6aca081..0c80812cc6f 100644 >> --- a/gdbserver/linux-amd64-ipa.cc >> +++ b/gdbserver/linux-amd64-ipa.cc >> @@ -164,47 +164,21 @@ supply_static_tracepoint_registers (struct regcache >> *regcache, >> >> #endif /* HAVE_UST */ >> >> -#if !defined __ILP32__ >> -/* Map the tdesc index to xcr0 mask. */ >> -static uint64_t idx2mask[X86_TDESC_LAST] = { >> - X86_XSTATE_X87_MASK, >> - X86_XSTATE_SSE_MASK, >> - X86_XSTATE_AVX_MASK, >> - X86_XSTATE_MPX_MASK, >> - X86_XSTATE_AVX_MPX_MASK, >> - X86_XSTATE_AVX_AVX512_MASK, >> - X86_XSTATE_AVX_MPX_AVX512_PKU_MASK, >> -}; >> -#endif >> - >> /* Return target_desc to use for IPA, given the tdesc index passed by >> gdbserver. */ >> >> const struct target_desc * >> get_ipa_tdesc (int idx) >> { >> - if (idx >= X86_TDESC_LAST) >> - { >> - internal_error ("unknown ipa tdesc index: %d", idx); >> - } >> + uint64_t xcr0 = x86_linux_tdesc_idx_to_xcr0 (idx); >> >> #if defined __ILP32__ >> - switch (idx) >> - { >> - case X86_TDESC_SSE: >> - return amd64_linux_read_description (X86_XSTATE_SSE_MASK, true); >> - case X86_TDESC_AVX: >> - return amd64_linux_read_description (X86_XSTATE_AVX_MASK, true); >> - case X86_TDESC_AVX_AVX512: >> - return amd64_linux_read_description (X86_XSTATE_AVX_AVX512_MASK, >> true); >> - default: >> - break; >> - } >> + bool is_x32 = true; >> #else >> - return amd64_linux_read_description (idx2mask[idx], false); >> + bool is_x32 = false; >> #endif >> >> - internal_error ("unknown ipa tdesc index: %d", idx); >> + return amd64_linux_read_description (xcr0, is_x32); >> } >> >> /* Allocate buffer for the jump pads. The branch instruction has a >> @@ -272,11 +246,10 @@ void >> initialize_low_tracepoint (void) >> { >> #if defined __ILP32__ >> - amd64_linux_read_description (X86_XSTATE_SSE_MASK, true); >> - amd64_linux_read_description (X86_XSTATE_AVX_MASK, true); >> - amd64_linux_read_description (X86_XSTATE_AVX_AVX512_MASK, true); >> + for (auto i = 0; i < x86_linux_x32_tdesc_count (); i++) >> + amd64_linux_read_description (x86_linux_tdesc_idx_to_xcr0 (i), true); >> #else >> - for (auto i = 0; i < X86_TDESC_LAST; i++) >> - amd64_linux_read_description (idx2mask[i], false); >> + for (auto i = 0; i < x86_linux_amd64_tdesc_count (); i++) > > I still dislike auto here ;) Change to 'int'. Apologies if I missed this comment on an earlier review. > But I guess since I couldn't come up with anything more meaningful: > Approved-By: Felix Willgerodt Thanks. > > Let's hope that we can tackle getting rid of the table at some point after > the MPX removal. Absolutely. This series is back on my radar. Once this is landed I want to push ahead with the next iteration of merging the tdesc caching for all x86 targets, not just Linux. Thanks, Andrew > > Thanks, > Felix > > Intel Deutschland GmbH > Registered Address: Am Campeon 10, 85579 Neubiberg, Germany > Tel: +49 89 99 8853-0, www.intel.de > Managing Directors: Sean Fennelly, Jeffrey Schneiderman, Tiffany Doon Silva > Chairperson of the Supervisory Board: Nicole Lau > Registered Office: Munich > Commercial Register: Amtsgericht Muenchen HRB 186928