From: Dmitry.Neverov <dmitry.neverov@jetbrains.com>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v3][PR symtab/30520 1/4] gdb/symtab: check name matches before expanding a CU
Date: Wed, 08 May 2024 13:32:47 +0200 [thread overview]
Message-ID: <87le4kmtcw.fsf@lubuntu2.mail-host-address-is-not-set> (raw)
In-Reply-To: <87edada70o.fsf@tromey.com>
Tom Tromey <tom@tromey.com> writes:
> Dmitry> + symbol_name_matcher_ftype *name_matcher
> Dmitry> + = lang_def->get_symbol_name_matcher
> Dmitry> + (last_segment_lookup_name);
>
> This also looks weird by gdb rules.
Do I understand correctly that it should look like this:
symbol_name_matcher_ftype *name_matcher = lang_def
->get_symbol_name_matcher (last_segment_lookup_name);
?
How do I send an updated patch? I've read the Contribution Checklist,
but didn't find the answer. Do I amend the commit and 'git send-mail' it
again with proper '--in-reply-to'?
--
Dmitry
next prev parent reply other threads:[~2024-05-08 11:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-06 15:09 Dmitry Neverov
2024-05-06 15:09 ` [PATCH v3][PR symtab/30520 2/4] gdb/symtab: reuse last segment lookup name info by creating it outside the loop Dmitry Neverov
2024-05-07 17:09 ` Tom Tromey
2024-05-06 15:09 ` [PATCH v3][PR symtab/30520 3/4] gdb/symtab: compute match_type " Dmitry Neverov
2024-05-07 17:10 ` Tom Tromey
2024-05-06 15:09 ` [PATCH v3][PR symtab/30520 4/4] gdb/symtab: use symbol name matcher for all segments in a qualified name Dmitry Neverov
2024-05-06 15:23 ` Dmitry Neverov
2024-05-07 17:26 ` Tom Tromey
2024-05-07 17:03 ` [PATCH v3][PR symtab/30520 1/4] gdb/symtab: check name matches before expanding a CU Tom Tromey
2024-05-08 11:32 ` Dmitry.Neverov [this message]
2024-05-08 15:48 ` Tom Tromey
2024-05-09 5:55 ` Dmitry.Neverov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87le4kmtcw.fsf@lubuntu2.mail-host-address-is-not-set \
--to=dmitry.neverov@jetbrains.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).