From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x1036.google.com (mail-pj1-x1036.google.com [IPv6:2607:f8b0:4864:20::1036]) by sourceware.org (Postfix) with ESMTPS id 42A3A384AB55 for ; Mon, 22 Apr 2024 16:15:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 42A3A384AB55 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 42A3A384AB55 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::1036 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713802528; cv=none; b=KxhwCkNPeP7XJ2wZaq2ORa8QMM25ROAi4hCZ6QhK2Fl9s/bDnhcSzeM60lEyGkwYRv04UdSGmjpMSc9TY4H6zvktRWfTuCqCHPAoc0Is7piTmSAzsiueukA0s7cOkQTLs4UdIIYv92DTXGHwO2RlRKCGvM6v0FuLdnhPzKfX6UE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713802528; c=relaxed/simple; bh=h4ynrCIApVsA5QMHK/gI995UYfbSTKnCnFyaIoLH34U=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=K8VvvKWgiGKR65UtrxhusJtYddAAWU19zLXElfptdp3mvIvgBQgYbLe4Yu8zTA6u0YNX3HNiRGpzrcfo99SrMVSsybnzo5aknVfPeriY3biP2Ns5odqflqXMKIdHLUVNeHWN6MFq0o1uSVR4xPqnPA+0BZAh8WjOUFsRTHbauGU= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pj1-x1036.google.com with SMTP id 98e67ed59e1d1-2a484f772e2so2971255a91.3 for ; Mon, 22 Apr 2024 09:15:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1713802523; x=1714407323; darn=sourceware.org; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=h4ynrCIApVsA5QMHK/gI995UYfbSTKnCnFyaIoLH34U=; b=XXphPQvCZ70fa0G3x3x4cOANS5CZBNGebVuSZFpW+jYCmfNnaySxy2k1qoV/3SPvGx NWGnB1zQaEQIlqasW7xCUT8Pj6qdy0Ajdbs3rzU/1Y2u8jEQgjAAc71t/1m8sG7ZCsbg gSq6Apj2r1AZfcaPuPPI4mRO7r2QgrdPSgs3p9VSM9RXcE+lnosW9jcoSeAcOJinO7KD gvb909BwG1hKmQ3V8ibr2skdO0SvH8+DtvHVDRE8QjlILTJQ/ReH0UjtWNxDXyYpR1mB geuAhCigsR+726w0Hfaq3HnKmy+Aah+HM8X0HmUlwQ89bQH+YjX7LswQQ7iw99zem4hk vEhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713802523; x=1714407323; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=h4ynrCIApVsA5QMHK/gI995UYfbSTKnCnFyaIoLH34U=; b=HPMcTWic55jJAetY3Ee5N46NZ9QoHuDYxJzQZGqk8sqxUQBViIzz5YCcpd3F3avAIA B3mTPsrlGYlYK26Xgs783c+b/djbyc1m2Uqp8pjxxhiBPxhZr/NqcoJX0rDpdmGeC8cl Vv5dh8CMpD8hLiyGuMcZguxBGb7DcatCfWqy/QK7af7Eh4HG4QEWL0rh/h7nfd5uxpCC y5R05mQduXkbtorCi3dPIsY2WiHd+uEv0lpTBdSyM0fwT1l7ohHolAmbcEUkaGX+sjBh TIjhKLgyo/1q1OY0HHnepzyVev0OzQHY/Cbu/5sIX/9dMxN0gUdTCRDBaxHaGx3J/bHU +tiQ== X-Gm-Message-State: AOJu0YybLzodScT7JqvwZfOalb8NKftsCK3/HOv/G2yMxgDyyjbqxrPI ssUFjgZoq8NyIBmktv6z3jgeH3Om4qtjbv1sTF41ib//RJZWUns/DljXeap9J6k21WliEI/8Eyi Y X-Google-Smtp-Source: AGHT+IHMjzY3YNvVxsrXbRj2CD0k7IfnHnUnuHX2QhHmZK1ngDW7If1oZI0RlcgmsEmHchoigoYmDA== X-Received: by 2002:a17:90a:f2d7:b0:2ae:3ffe:cca1 with SMTP id gt23-20020a17090af2d700b002ae3ffecca1mr1892735pjb.21.1713802523137; Mon, 22 Apr 2024 09:15:23 -0700 (PDT) Received: from localhost ([2804:14d:7e39:8470:87aa:da06:1597:160d]) by smtp.gmail.com with ESMTPSA id v17-20020a17090ad59100b0029c19285192sm9608411pju.44.2024.04.22.09.15.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Apr 2024 09:15:22 -0700 (PDT) From: Thiago Jung Bauermann To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] gdb/testsuite: Use default gdb_expect timeout in runto In-Reply-To: <87bk61sc9k.fsf@tromey.com> (Tom Tromey's message of "Mon, 22 Apr 2024 08:27:51 -0600") References: <20240420165903.930352-1-thiago.bauermann@linaro.org> <87bk61sc9k.fsf@tromey.com> User-Agent: mu4e 1.12.4; emacs 29.3 Date: Mon, 22 Apr 2024 13:15:20 -0300 Message-ID: <87le552x2f.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hello Tom, Tom Tromey writes: >>>>>> "Thiago" == Thiago Jung Bauermann writes: > > Thiago> runto uses a hard-coded timeout of 30s in its invocation of gdb_expect. > Thiago> This is normally fine, but for very a slow system (e.g., an emulator) it > Thiago> may not be enough time for GDB to reach the intended breakpoint. > > Thiago> gdb_expect can obtain a timeout value from user-configurable variables > Thiago> when it's not given one explicitly, so use that mechanism instead since > Thiago> the user will have already adjusted the timeout variable to account for > Thiago> the slow system. > > This seems fine to me. > Approved-By: Tom Tromey Thank you! Pushed as commit fdaa4939e502. -- Thiago