From: Tom Tromey <tom@tromey.com>
To: Pedro Alves <pedro@palves.net>
Cc: Andrew Burgess <aburgess@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb/linux-nat: Fix mem access ptrace fallback (PR threads/31579)
Date: Mon, 15 Apr 2024 10:05:07 -0600 [thread overview]
Message-ID: <87le5e393g.fsf@tromey.com> (raw)
In-Reply-To: <2846f8ac-bd84-4641-85ad-c585cd49d37b@palves.net> (Pedro Alves's message of "Fri, 12 Apr 2024 18:02:31 +0100")
>>>>> "Pedro" == Pedro Alves <pedro@palves.net> writes:
>> s/NULL/nullptr/ ?
Pedro> Personally, I prefer writing NULL in comments than nullptr, because saying (I mean,
Pedro> imagine reading the comment aloud) "null ptr" is kind of awkward, in my mind.
Pedro> It see it more as NULL meaning "the null pointer value", i.e., the word "null"
Pedro> uppercased, than literally the NULL macro. I've seen other patches from others
Pedro> using NULL in comments so I thought it was other's preference as well.
Yeah, I prefer this in comments as well. I'm not really sure why but
maybe because the all-caps makes it more distinct.
Tom
prev parent reply other threads:[~2024-04-15 16:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-11 11:39 Pedro Alves
2024-04-12 10:44 ` Hannes Domani
2024-04-12 16:05 ` Andrew Burgess
2024-04-12 17:02 ` Pedro Alves
2024-04-15 16:05 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87le5e393g.fsf@tromey.com \
--to=tom@tromey.com \
--cc=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=pedro@palves.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).