From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from omta034.useast.a.cloudfilter.net (omta034.useast.a.cloudfilter.net [44.202.169.33]) by sourceware.org (Postfix) with ESMTPS id 2B3C83858D32 for ; Mon, 15 Apr 2024 16:05:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2B3C83858D32 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 2B3C83858D32 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.33 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713197120; cv=none; b=TQynhpcf7fuyM3CzZAGttzGgKSaEK7j2VAWC/ltWKkhv0ecdEPwbVv2UR/vm6FFoMxWnDknuG6HUBDC6ydQM2iOICtL7MxzmmoyWiYgjyoseGcRax55DBbbVpfK9Jji5ZcmhdQzan9Y0wk9avfRO+0iVa+sBNQiSmEVqvY7gn6s= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713197120; c=relaxed/simple; bh=N9F1tbkcreZjWOiiqymYF1CtAyyMWyJVF3VtaXJaltg=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=OaVDru7EKWAszG2nffGXtvoDvCBpRy8K1qCa50s82PkEEynYFTpDz08BD7ZPOSBUFKqhuLV5wULUdEJly9j87UD5Hgl4xDBB+H1aqkYJ+Xqubl24c/rgNGyU6Rg0GxI4kLLGR57PzLCUpV8JfgKORrLqDoKlNeoSS6bPptJdPUQ= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-5006a.ext.cloudfilter.net ([10.0.29.179]) by cmsmtp with ESMTPS id wLJerI0CNs4yTwOpRrDDtw; Mon, 15 Apr 2024 16:05:09 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id wOpQrlxqBqaR9wOpRrtwrc; Mon, 15 Apr 2024 16:05:09 +0000 X-Authority-Analysis: v=2.4 cv=MqZU6Xae c=1 sm=1 tr=0 ts=661d5035 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=raytVjVEu-sA:10 a=Qbun_eYptAEA:10 a=T_Alst9gAAAA:8 a=l_xgmI2Oxc7Snlj-tMQA:9 a=DvZ5ixILWSEuw56YIEpp:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=xXQhTYUsCc7Q75RdD191dAB2zRgaPAsY2wFyklKq3FY=; b=DfDF77jpkvWESss5l3P3+snmSO T10HJu9v6FmT7W4XLJ5uQarSpmqYubfNFG1s0ILBixOLCcS6c9G6SZ6k8Ot3tDzvjL+ayTNq3B+tC 0U6DQCIQHvZrTFT/8J8nkz6xN; Received: from 97-122-82-115.hlrn.qwest.net ([97.122.82.115]:57146 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1rwOpQ-003TFe-1R; Mon, 15 Apr 2024 10:05:08 -0600 From: Tom Tromey To: Pedro Alves Cc: Andrew Burgess , gdb-patches@sourceware.org Subject: Re: [PATCH] gdb/linux-nat: Fix mem access ptrace fallback (PR threads/31579) References: <20240411113941.204268-1-pedro@palves.net> <8734rq5zy2.fsf@redhat.com> <2846f8ac-bd84-4641-85ad-c585cd49d37b@palves.net> X-Attribution: Tom Date: Mon, 15 Apr 2024 10:05:07 -0600 In-Reply-To: <2846f8ac-bd84-4641-85ad-c585cd49d37b@palves.net> (Pedro Alves's message of "Fri, 12 Apr 2024 18:02:31 +0100") Message-ID: <87le5e393g.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.82.115 X-Source-L: No X-Exim-ID: 1rwOpQ-003TFe-1R X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-82-115.hlrn.qwest.net (murgatroyd) [97.122.82.115]:57146 X-Source-Auth: tom+tromey.com X-Email-Count: 3 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfJ2R/Vjh/51fg000qWzvuwCgL/Yd1M3Yqz7jcRhiN03k+ONqNaTJruGpv+2ExrNOKaJgJjOaaRHpDL5CvrtMpYJm0o6XC0gYf2I8oLscER7+67tlZW+W 4i9PKNKx5AEC0NzpWVTr8P6ITYwxmE3/VsbxNYA68Uo02a94bnBh0ZrhXQ/uxduJVbxuodDlulLqq3gbRCcQYdSocAo3rEsRSTc= X-Spam-Status: No, score=-3015.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Pedro" == Pedro Alves writes: >> s/NULL/nullptr/ ? Pedro> Personally, I prefer writing NULL in comments than nullptr, because saying (I mean, Pedro> imagine reading the comment aloud) "null ptr" is kind of awkward, in my mind. Pedro> It see it more as NULL meaning "the null pointer value", i.e., the word "null" Pedro> uppercased, than literally the NULL macro. I've seen other patches from others Pedro> using NULL in comments so I thought it was other's preference as well. Yeah, I prefer this in comments as well. I'm not really sure why but maybe because the all-caps makes it more distinct. Tom