From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x632.google.com (mail-pl1-x632.google.com [IPv6:2607:f8b0:4864:20::632]) by sourceware.org (Postfix) with ESMTPS id 4CE073858D37 for ; Wed, 28 Feb 2024 03:16:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4CE073858D37 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 4CE073858D37 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::632 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709090170; cv=none; b=xJDNwlwCEZdpRnxkeYArXAzRtuMqFQAech3REu/HPp4xNqhvOpWw+oWkUp3O7hqAyhlP5WLXPPiBCx/OqyI/IkO4gATgwOAiXyTMgT6TAqs7BFQdRCLRK6SbM+Y5R57BW4t6jLytmIi5nx7jC2zgx/MRK7OseoWAeZp3PoVBYW4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709090170; c=relaxed/simple; bh=SHE2afJU8am9rn7ZXXwOIND7+3R9GTCLnqETb4IDeO0=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=AQBfcPLNiGTx1g+HOBAJB8/PTcsPw8wwfSy0OqEG5leWsouxOV4LcjiMv36kDsJyNJMt5XoYcAAcbHrMv+GbxjanoLZvXP0hxYl3d+KZXtmgC3dlOF05zoc8f19ZUJYo3gB7aASNH6kajmbGP2oKf27O6sv7VjNZoJQaNfgMi9c= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pl1-x632.google.com with SMTP id d9443c01a7336-1dc9222b337so31432855ad.2 for ; Tue, 27 Feb 2024 19:16:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1709090167; x=1709694967; darn=sourceware.org; h=mime-version:message-id:date:in-reply-to:subject:cc:to:from :user-agent:references:from:to:cc:subject:date:message-id:reply-to; bh=v9J0SQT1kjMSw0BmSGuKxsuvReL97WQCdX/Pos0s1Og=; b=Sx8xu9bS4FIKqL6yF+LMlVIuaIbIHNAR/N84+ryD/4AlX/1+nbPUx5xRTKHkZKht56 k3TGOz3uqsu/4SyfFr5qiqA5dFdupwl67fE9WUNxTKJeATymD7fsS3FXW6J0cI6L3fls Wr6Et5oH8LVefIH34nx0KcEHJdH5rf0mfg1QqiEEsNmyjXbeoQ/UTL13AwtsnsAOIQza DLGZb7bDZQpwkdnoeeJwPJPHpSAnzguTSsDAuYcVMnpC+sA2lw1QJNYaUcKzJNjUU81J hgjlYx/RDZy7rO+iEyaw836FLuBxsuwTHWsv+ZmH/ZWOhyCvM6YGiIys0+cJwSVRITms l9CA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709090167; x=1709694967; h=mime-version:message-id:date:in-reply-to:subject:cc:to:from :user-agent:references:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=v9J0SQT1kjMSw0BmSGuKxsuvReL97WQCdX/Pos0s1Og=; b=oCPf/8rEwCGGe3yT5yWrJi0ZEFwYVe/rboz9TguOC1KqtzSING1tGgCr3bAMZp7gwN Fph86UpNK9IFCc4qdgtv5zXVR7mFzesd+yz4mrVJRiRzyr22LNivSj77qyRzjitUUUfd 0sTLDkVGv8M1cp2ZXvtx72/meMkHlaxK0zCpgyLdyWQUWImPa7nbwwss5GLAKQJkgEPg X9yyzJyODWGXfJ5kkSEZ1q658lxzmEpv7L0vJs/N5vhJ75Z8BLdA5ACfJcdJUyCvtu8o jO1g24rUmz0pqzrHReQ+v+T13gAXLuJVOmcUHLELRlfy3gKjsGgd4rAkYTOqsX4wB0jT szGA== X-Gm-Message-State: AOJu0YzB3hupSJ66FI8G5TmLFHctHl332aZC3WxaV5z56pFns+yDQXF7 keWoULXDtN9MWwQOd2GlZZdioETU7LFXfWwUCgWsYAd43/rpda/gtyRTOUW1hqRRb7iCzcMz2eP oh0w= X-Google-Smtp-Source: AGHT+IFb0I0iZyNuVLEbGGA2BvMmB5B78uuwHW+sqdz6X60KkclRy5KjUwHTBP9YwQF9xNshy7ZHfg== X-Received: by 2002:a17:902:d2c5:b0:1db:be69:d02d with SMTP id n5-20020a170902d2c500b001dbbe69d02dmr16973524plc.32.1709090167259; Tue, 27 Feb 2024 19:16:07 -0800 (PST) Received: from localhost ([2804:14d:7e39:8470:d617:f08f:e330:49c1]) by smtp.gmail.com with ESMTPSA id r19-20020a170902be1300b001d913992d8csm2207417pls.242.2024.02.27.19.16.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Feb 2024 19:16:06 -0800 (PST) References: <20240227214851.350579-1-thiago.bauermann@linaro.org> User-agent: mu4e 1.10.8; emacs 29.1 From: Thiago Jung Bauermann To: John Baldwin Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] gdb/arm: Remove tpidruro register from non-FreeBSD target descriptions In-reply-to: Date: Wed, 28 Feb 2024 00:16:05 -0300 Message-ID: <87le758eiy.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: John Baldwin writes: > On 2/27/24 1:48 PM, Thiago Jung Bauermann wrote: >> Therefore, disable the TLS feature in aarch32 target descriptions for Linux >> and NetBSD targets (the latter also doesn't seem to support accessing >> tpidruro either, based on a quick look at arm-netbsd-nat.c). >> This patch fixes the following tests: >> Running gdb.base/inline-frame-cycle-unwind.exp ... >> FAIL: gdb.base/inline-frame-cycle-unwind.exp: cycle at level 3: backtrace when the >> unwind is broken at frame 3 >> FAIL: gdb.base/inline-frame-cycle-unwind.exp: cycle at level 5: backtrace when the >> unwind is broken at frame 5 >> FAIL: gdb.base/inline-frame-cycle-unwind.exp: cycle at level 1: backtrace when the >> unwind is broken at frame 1 >> Tested with Ubuntu 22.04.3 on armv8l-linux-gnueabihf in native, >> native-gdbserver and native-extended-gdbserver targets with no regressions. >> PR tdep/31418 >> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=31418 > > This looks good to me. > > Approved-By: John Baldwin Thank you for the quick review! Unfortunately I saw an issue after I posted the patch, and just sent a v2. Sorry about that. Fortunately, the only change is in gdb/aarch32-tdep.c. -- Thiago