From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from omta40.uswest2.a.cloudfilter.net (omta40.uswest2.a.cloudfilter.net [35.89.44.39]) by sourceware.org (Postfix) with ESMTPS id 8C2633858C42 for ; Sat, 9 Dec 2023 16:06:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8C2633858C42 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 8C2633858C42 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.39 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702137994; cv=none; b=vgr44kxx3GOPHtY345Cle3/+UhN3J8bujdNSMX96Xj9xVPzQX7KdWdHR1fES/3gGak3gpVBZzchCI/klk0aijiiQq3fRP3+WuvWUzMPsVlwMjnWTWAO7NrDEjCWwUypfp4Rh+5uqUCOSfQDP7fGX9dMUsIaPJfhQvc+da+bZ/Xs= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702137994; c=relaxed/simple; bh=ca8yM3cA1Hd0NSOQfkgJQaJVfkG8iw12nVkygQDN9Aw=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=NSrvSxisgiM1rJxA+DFA8LFM28bQD/5sG1rxfJoktbJ9hOc37aaNtD96cbi5dKlD3zPEBdxunlpMJkT5qSkpkckEsazr6AVB4m/mkE5l+zBqUt5OYuq9DMCNzevxZ0BoJ8+Ce+Zeo5O3vgWVwgVrgHLiZQeyjC4ZChILrc7PMpo= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-5006a.ext.cloudfilter.net ([10.0.29.179]) by cmsmtp with ESMTPS id BeCpr4flhL9AgBzqYrSi3M; Sat, 09 Dec 2023 16:06:30 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id BzqXruXRO1J28BzqXrtRB8; Sat, 09 Dec 2023 16:06:29 +0000 X-Authority-Analysis: v=2.4 cv=Tqz1ORbh c=1 sm=1 tr=0 ts=65749085 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=OWjo9vPv0XrRhIrVQ50Ab3nP57M=:19 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=e2cXIFwxEfEA:10 a=Qbun_eYptAEA:10 a=oJydF8Nq_vkVz0lOy7YA:9 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=/cVjZeiT/ShkbnYvJMU/M1g3VOapWVEKWs/zoWC37/s=; b=G+NfiufjobNTJrH8sBdIUPo80n aJdiuCzh+mTTp5p57t7oQbZugm3heFMjraJnSyepaR/ts+oOKgwrS3yQdeSP7AxSeN1EoIvYje+3T Hbk/fvznHPrHJ7ADkz2aC67g9; Received: from 71-211-161-25.hlrn.qwest.net ([71.211.161.25]:48718 helo=prentzel) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1rBzqX-0048Hy-01; Sat, 09 Dec 2023 09:06:29 -0700 From: Tom Tromey To: Tom de Vries Cc: gdb-patches@sourceware.org, Tom Tromey Subject: Re: [PATCH] [gdb/tui] Assert on tui_refreshing_registers recursion References: <20231209082453.21019-1-tdevries@suse.de> X-Attribution: Tom Date: Sat, 09 Dec 2023 09:06:27 -0700 In-Reply-To: <20231209082453.21019-1-tdevries@suse.de> (Tom de Vries's message of "Sat, 9 Dec 2023 09:24:53 +0100") Message-ID: <87lea3743g.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.161.25 X-Source-L: No X-Exim-ID: 1rBzqX-0048Hy-01 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-161-25.hlrn.qwest.net (prentzel) [71.211.161.25]:48718 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfKC3DXTjSvSSfGaH/922byAHk433S+qrmAENo41ed6gq4yK8/ypsTb+vpmdcje7Hy/TM8nvjavaPrfIkVyy3QwCAQcICmvifLWWxKv1M70ZIiuo/boyC SCEGb7CVQZNzvQOm7gwroj1avYkGpVhd1AoTg1wxfxM8hjYA1b68Etvv6UxhAKVvx7C8rAmEb3d8J2D3+Aq/ObouQIqrxBpWNOE= X-Spam-Status: No, score=-3016.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Tom" == Tom de Vries writes: Tom> Change the behaviour from preventing recursion to asserting on detecting Tom> recursion. If there is a bug here, it will be inflicted on users in the form of a crash -- so I tend to think that it is better to just leave some ugly code in there. Probably the real way to convince ourselves it is ok to remove is following the code paths by hand, but of course in the TUI that's a pain. Tom