From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 8D3E33858D28 for ; Mon, 9 Oct 2023 14:32:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8D3E33858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1696861948; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NwLTSRxftnLE9JQoqJOyyA4iP7+KoqixdxQ0GSPSJrY=; b=UiSgJmHjOliJ5tvt5cNLJ7+8FVQ9Io4egdUyd+452kW2kp0e4GdnQDSeLZP40BaHd/Vb3q Zx65CPGncdByU44PpFPv7PCzL/OThkpkoSGwidkUb8IK8lBERW+cL3wGj9dUPrkxRFM5TF zQDoXHUUGWy71ZjnWL3YkBV/XSJ3LU4= Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-15-9EPCXv88NwyrDlplX7ZOoQ-1; Mon, 09 Oct 2023 10:32:26 -0400 X-MC-Unique: 9EPCXv88NwyrDlplX7ZOoQ-1 Received: by mail-ej1-f70.google.com with SMTP id a640c23a62f3a-9a681c3470fso374436666b.1 for ; Mon, 09 Oct 2023 07:32:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696861945; x=1697466745; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NwLTSRxftnLE9JQoqJOyyA4iP7+KoqixdxQ0GSPSJrY=; b=rEqvCB3/csfEXp/wWyymfzFjxSDh7F+NjuLvK5HBOYkf4aMLluSk9qqqbB7PUNNpjj QpN5LI+2o16iBaM/qHzVOEVZ9HX2gY08xy5QsMtCtsbDpe779QIRKQiS8dyj0WKPlF5o HcFCsZuE5GOEZ+Q7ZznXq+H7XQLIMZlenbTBD7/OYn0qvhn3y0YS2QS43tJYabnp0wi0 Bbdny0Z3XWQpE69P2FUsWAv271Py9ftEBZ2CErRKyyKZze6MTMkAaW9oXanLaJhtXPEF qyNDUBLwHs7+IPyjNaTlhERocpye1jLbANjBekqnRQe5JWSgOktmAeSGeU5rlLrzldYO ChFQ== X-Gm-Message-State: AOJu0YxqMYs4ch+JOby+LISzDvqXthDzp+x5bfwUjS86gSCqn9c0pVR6 9DibfsOvRVaoc8RYwEduVPFmLyRuDFVzee4Rjd5gbWt1on9UZuSI5/1PtIk03tcSGOAvMPOHk1N Ug9qS42vr7Z0nFQ150zekSgPHM2DYRQ== X-Received: by 2002:a17:906:3150:b0:9a1:f81f:d0d5 with SMTP id e16-20020a170906315000b009a1f81fd0d5mr13168620eje.54.1696861945621; Mon, 09 Oct 2023 07:32:25 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEt/CXXXiHa3JMt3f2b89WNZ/7kWRdZeFRxKUwjpmRhHKr88ywRf6PkuHFwObO/s8H39miMTg== X-Received: by 2002:a17:906:3150:b0:9a1:f81f:d0d5 with SMTP id e16-20020a170906315000b009a1f81fd0d5mr13168598eje.54.1696861945241; Mon, 09 Oct 2023 07:32:25 -0700 (PDT) Received: from localhost ([31.111.84.209]) by smtp.gmail.com with ESMTPSA id a23-20020a17090680d700b00993cc1242d4sm6756088ejx.151.2023.10.09.07.32.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Oct 2023 07:32:24 -0700 (PDT) From: Andrew Burgess To: Lancelot SIX , Simon Marchi , Tom de Vries Cc: gdb-patches@sourceware.org Subject: Re: [PATCH RFC] Require c++17 compiler In-Reply-To: <3c031ebd-4011-48f7-9cf5-0bd87797808c@amd.com> References: <20231005065449.32643-1-tdevries@suse.de> <20231005103354.5loeki67slszfrcy@hpe6u-23> <87h6n5tfu9.fsf@redhat.com> <3c031ebd-4011-48f7-9cf5-0bd87797808c@amd.com> Date: Mon, 09 Oct 2023 15:32:23 +0100 Message-ID: <87lecbdfyg.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-5.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Lancelot SIX writes: >>=20 >> Wouldn't it be a simple find and replace, gdb::optional to >> std::optional? Conveniently, it's the same number of characters, so it >> doesn't even affect line-wrapping. >>=20 >> Simon > > I=E2=80=AFguess it is mostly true, there could be some cases where one ca= n do > > namespace gdb { > optional f; > } > > But I really don't think we have many of such occurrences. > > So in the end, I=E2=80=AFagree that that is a viable option with a big-is= h patch. I agree with Simon; when we move to C++17 we'll just rip out gdb::optional and have one big patch to move us to std::optional. I don't see this as a problem. We can easily do the same with gdb::make_unique too. Hopefully once GDB 14 releases, we can go ahead and move to C++17 so this issue will resolve itself. Thanks, Andrew