From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x634.google.com (mail-pl1-x634.google.com [IPv6:2607:f8b0:4864:20::634]) by sourceware.org (Postfix) with ESMTPS id 3E3D63858D35 for ; Tue, 3 Oct 2023 00:04:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3E3D63858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-pl1-x634.google.com with SMTP id d9443c01a7336-1c60a514f3aso2678685ad.3 for ; Mon, 02 Oct 2023 17:04:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1696291469; x=1696896269; darn=sourceware.org; h=content-transfer-encoding:mime-version:message-id:date:in-reply-to :subject:cc:to:from:user-agent:references:from:to:cc:subject:date :message-id:reply-to; bh=mpO4966Jhk3gdjVSfyyZrFcj3IcIrijEb7iWKjCaKJI=; b=uBcfj3imQcCQI/czAsNHbnSnA/U7Phm5atLGbfcm3J8I5/abVpu964r0+uUzX0QEIp JgRS5ylItuT/im2JrYr+J/0TqdFpwCV1wczalAJJvbva9wu3QMIxabdy0ZBJj5TQLKDs FdFZdLGbR4fa/QS+eTyyofTDwi2WGeCoi5iUtAQCZlLm2K1MQxjLXnel317WHyGwBaPe adn4O2gNiwCzi0MJRt85hDFaMWH4xF6LwkFyJhTK3px1VFNRhIFEJx3AvQD+4jyNWM4i N4GHpjaMgAvUf5D7CbZ4lh14Yf9GuHdEmaQFQlDXGLcI/7fxtxYD37I1L9uiRM2o/iag Bznw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696291469; x=1696896269; h=content-transfer-encoding:mime-version:message-id:date:in-reply-to :subject:cc:to:from:user-agent:references:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=mpO4966Jhk3gdjVSfyyZrFcj3IcIrijEb7iWKjCaKJI=; b=Jf8dFgEc2ScdQ2o+ykSzL/ew7xD4Gvi63b1msBZ8MMLwyyis7NSe897x6XVO6rWDpF y2ze6oQ81E/0FlRWotGLx/+orMRMtLRz7ivOBzcgzjYCde46wEycpFtl84ketX6pBxiB oGF9R/NzhEmYSG4PBMkp7mKpiwufUjtOs6sJbvVjSxSJLWLIJpAUc2CtV5zO6EHiUt6N ob6ihWE3huu9A6CEPItGv/beKHr803XwrIGmj8pacagl3Zk7Rms1NWHQKnichsllks3g fQ2+fZz0tZFb+c2+MfMjdP6aaV1dBeJPMszV3Rf4GEejHMjG6HPTzO485iMyA8HK/mq5 y/CQ== X-Gm-Message-State: AOJu0YzJAtezIAJa4xD+oPEocl1zSnf/NqAAlwU+zWGodJRZvRFwlSfm ZpyOTBDiqBlbzcLGhjLwE7mAow== X-Google-Smtp-Source: AGHT+IEdsVbiuUgox1DDd7ftx+4FM8pziIVupyAHq9vIcAYE4s/Fj5hxFl3RUlxt2w9P4cYEijHL5A== X-Received: by 2002:a17:902:d2ce:b0:1c3:ed30:ce0a with SMTP id n14-20020a170902d2ce00b001c3ed30ce0amr17430731plc.19.1696291469084; Mon, 02 Oct 2023 17:04:29 -0700 (PDT) Received: from localhost ([2804:14d:7e39:8470:c981:e91d:3861:6298]) by smtp.gmail.com with ESMTPSA id o12-20020a170902778c00b001bdc8a5e96csm32276pll.169.2023.10.02.17.04.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Oct 2023 17:04:28 -0700 (PDT) References: <20230904222956.15203-1-abdul.b.ijaz@intel.com> <20230904222956.15203-2-abdul.b.ijaz@intel.com> User-agent: mu4e 1.10.7; emacs 29.1 From: Thiago Jung Bauermann To: Abdul Basit Ijaz Cc: simark@simark.ca, tom@tromey.com, gdb-patches@sourceware.org Subject: Re: [PATCH v3 1/4] gdb, testsuite: handle icc and icpc deprecated remarks In-reply-to: <20230904222956.15203-2-abdul.b.ijaz@intel.com> Date: Mon, 02 Oct 2023 21:04:25 -0300 Message-ID: <87leckefli.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-11.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hello, Abdul Basit Ijaz via Gdb-patches writes: > diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp > index 1b9179401c4..def6a75dfee 100644 > --- a/gdb/testsuite/lib/gdb.exp > +++ b/gdb/testsuite/lib/gdb.exp > @@ -4980,13 +4980,15 @@ proc gdb_compile {source dest type options} { > } > } >=20=20 > - # Starting with 2021.7.0 (recognized as icc-20-21-7 by GDB) icc and > - # icpc are marked as deprecated and both compilers emit the remark > - # #10441. To let GDB still compile successfully, we disable these > - # warnings here. > + # Starting with 2021.7.0 (recognized as icc-20-21-7 by > + # GDB) icc and icpc are marked as deprecated and both > + # compilers emit the remark #10441. To let GDB still > + # compile successfully, we disable these warnings here. I don't see any change in this comment except for the reformatting. IMO, the text is more readable at the larger width and considering that it's already less than 80 columns, I suggest dropping this part of the change. > if {([lsearch -exact $options c++] !=3D -1 > - && [test_compiler_info {icc-20-21-[7-9]} c++]) > - || [test_compiler_info {icc-20-21-[7-9]}]} { > + && [test_compiler_info {icc-20-21-[7-9]} c++] > + && [test_compiler_info {icc-20-21-[1-9][0-9]} c++]) Unless I'm missing something, the above should be: ([lsearch =E2=80=A6] !=3D -1 && ([test_compiler_info c++] || [test_compiler_info c++]) > + || [test_compiler_info {icc-20-21-[7-9]}] > + || [test_compiler_info {icc-20-21-[1-9][0-9]}]} { > lappend new_options "additional_flags=3D-diag-disable=3D10441" > } > } --=20 Thiago