Re: [PATCH] gdb: Fix an ODR warning with byacc with GDB_YY_REMAP

[Sam James <sam@gentoo.org>]

Tom de Vries <tdevries@suse.de> writes:

> On 9/28/23 04:56, Sam James wrote:
>> Tom de Vries <tdevries@suse.de> writes:
>> 
>>> On 9/27/23 09:35, Sam James wrote:
>>>> Tom de Vries <tdevries@suse.de> writes:
>>>>
>>>>> On 9/26/23 15:48, Tom Tromey wrote:
>>>>>>>>>>> "Tom" == Tom de Vries via Gdb-patches <gdb-patches@sourceware.org> writes:
>>>>>> Tom> On 9/12/23 02:58, Sam James wrote:
>>>>>>>> - Tom commented that it probably constitutes obvious but while I
>>>>>>>> have binutils access, I'm not listed in gdb/MAINTAINERS for
>>>>>>>> write-after-approval, so I'm hesitant.
>>>>>> Tom> GDB write-after-approval requires a copyright assignment that
>>>>>> covers
>>>>>> Tom> gdb.  Do you have a copyright assignment for gdb?
>>>>>> I think this patch could land without the paperwork, since it is
>>>>>> small.
>>>>>
>>>>> Agreed, which is why I've already approved it and asked Sam to commit it.
>>>>>
>>>>>> And, it would be good to get it in before GDB 14, since it is a build
>>>>>> fix.
>>>>>
>>>>> Agreed.  Sam, is there anything preventing you from committing this?
>>>>> If so, then I can take care of it.
>>>> Sorry folks, done now - Tom's question had prompted me to go finally
>>>> figure out the copyright assignment bits and I got distracted.
>>>> Pushed!
>>>>
>>>
>>> Hi,
>>>
>>> thanks for pushing it.
>>>
>>> I saw you used a Copyright-paperwork-exempt tag, it's good to make
>>> that explicit (FWIW, I was not familiar with the tag itself, but I see
>>> there's prior usage).
>>>
>>> Just want to mention: my understanding is that this commit goes into
>>> the bucket legally insignificant contributions.  If you keep adding
>>> similar commits, at some point this bucket will overflow and you need
>>> a copyright assignment to keep contributing regardless of the nature
>>> of the patch.  I wish these things were less complicated ...
>> Thank you! I've just had the email from the FSF saying it's all done
>
> Ah, that makes things much easier :)
>
>> (it was in-flight for a while but I needed to do some bits to finish it off).
>> I appreciate the nudge to get this done, it was overdue anyway and
>> I was putting it off.
>> Would you mind if I added myself to write-after-approval?
>
> Please do so.

Done - thank you!

>
> Thanks,
> - Tom

best,
sam