From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.gentoo.org (woodpecker.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) by sourceware.org (Postfix) with ESMTP id 9FC373858C78 for ; Fri, 29 Sep 2023 04:38:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9FC373858C78 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gentoo.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gentoo.org References: <20230912010238.3086346-1-sam@gentoo.org> <87bkdp59la.fsf@tromey.com> <87cyy4cbks.fsf@gentoo.org> <8ed8360e-a553-49e9-93b1-a1ebcdaa52f6@suse.de> <87sf6zatsp.fsf@gentoo.org> User-agent: mu4e 1.10.6; emacs 30.0.50 From: Sam James To: Tom de Vries Cc: Sam James , Tom Tromey , Tom de Vries via Gdb-patches , Tom de Vries Subject: Re: [PATCH] gdb: Fix an ODR warning with byacc with GDB_YY_REMAP Date: Fri, 29 Sep 2023 05:37:59 +0100 Organization: Gentoo In-reply-to: Message-ID: <87lecpbnm9.fsf@gentoo.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-3.9 required=5.0 tests=BAYES_00,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Tom de Vries writes: > On 9/28/23 04:56, Sam James wrote: >> Tom de Vries writes: >> >>> On 9/27/23 09:35, Sam James wrote: >>>> Tom de Vries writes: >>>> >>>>> On 9/26/23 15:48, Tom Tromey wrote: >>>>>>>>>>> "Tom" == Tom de Vries via Gdb-patches writes: >>>>>> Tom> On 9/12/23 02:58, Sam James wrote: >>>>>>>> - Tom commented that it probably constitutes obvious but while I >>>>>>>> have binutils access, I'm not listed in gdb/MAINTAINERS for >>>>>>>> write-after-approval, so I'm hesitant. >>>>>> Tom> GDB write-after-approval requires a copyright assignment that >>>>>> covers >>>>>> Tom> gdb. Do you have a copyright assignment for gdb? >>>>>> I think this patch could land without the paperwork, since it is >>>>>> small. >>>>> >>>>> Agreed, which is why I've already approved it and asked Sam to commit it. >>>>> >>>>>> And, it would be good to get it in before GDB 14, since it is a build >>>>>> fix. >>>>> >>>>> Agreed. Sam, is there anything preventing you from committing this? >>>>> If so, then I can take care of it. >>>> Sorry folks, done now - Tom's question had prompted me to go finally >>>> figure out the copyright assignment bits and I got distracted. >>>> Pushed! >>>> >>> >>> Hi, >>> >>> thanks for pushing it. >>> >>> I saw you used a Copyright-paperwork-exempt tag, it's good to make >>> that explicit (FWIW, I was not familiar with the tag itself, but I see >>> there's prior usage). >>> >>> Just want to mention: my understanding is that this commit goes into >>> the bucket legally insignificant contributions. If you keep adding >>> similar commits, at some point this bucket will overflow and you need >>> a copyright assignment to keep contributing regardless of the nature >>> of the patch. I wish these things were less complicated ... >> Thank you! I've just had the email from the FSF saying it's all done > > Ah, that makes things much easier :) > >> (it was in-flight for a while but I needed to do some bits to finish it off). >> I appreciate the nudge to get this done, it was overdue anyway and >> I was putting it off. >> Would you mind if I added myself to write-after-approval? > > Please do so. Done - thank you! > > Thanks, > - Tom best, sam