From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from omta036.useast.a.cloudfilter.net (omta036.useast.a.cloudfilter.net [44.202.169.35]) by sourceware.org (Postfix) with ESMTPS id 592E53858D35 for ; Fri, 15 Sep 2023 17:46:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 592E53858D35 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from eig-obgw-5007a.ext.cloudfilter.net ([10.0.29.141]) by cmsmtp with ESMTP id hAPQqzoNiDKaKhCtIqHDIS; Fri, 15 Sep 2023 17:46:04 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id hCtHqP4HLiKVdhCtIqELLj; Fri, 15 Sep 2023 17:46:04 +0000 X-Authority-Analysis: v=2.4 cv=aryhtAVV c=1 sm=1 tr=0 ts=6504985c a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=OWjo9vPv0XrRhIrVQ50Ab3nP57M=:19 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=zNV7Rl7Rt7sA:10 a=Qbun_eYptAEA:10 a=CCpqsmhAAAAA:8 a=zstS-IiYAAAA:8 a=sLrteXTg-Bg5SDKiFjsA:9 a=ul9cdbp4aOFLsgKbc677:22 a=4G6NA9xxw8l3yy4pmD5M:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=YT3xSV/HOVKnTvU11rPkiOLKUNZS9bewkoxcAw4o8T4=; b=IsGZUhnW0aGRhCfd0uEphNVnJW WguugOFzBG2hpHnnMcfTxM26NnTuqniK6qcNbZjby8dAnFimRZec3ozG1K9TmY+1grc0h2I8YKNiy G33ThPBRVVheai056pzCAEGSs; Received: from 71-211-130-31.hlrn.qwest.net ([71.211.130.31]:54170 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1qhCtH-003D3t-17; Fri, 15 Sep 2023 11:46:03 -0600 From: Tom Tromey To: "Bouhaouel, Mohamed via Gdb-patches" Cc: "Bouhaouel, Mohamed" , "tom@tromey.com" Subject: Re: [PING][PATCH v3 1/1] gdb, breakpoint: add a destructor to the watchpoint struct References: <20230630081015.17380-1-mohamed.bouhaouel@intel.com> X-Attribution: Tom Date: Fri, 15 Sep 2023 11:46:02 -0600 In-Reply-To: (Mohamed via Gdb-patches Bouhaouel's message of "Fri, 15 Sep 2023 07:53:46 +0000") Message-ID: <87led79vol.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.130.31 X-Source-L: No X-Exim-ID: 1qhCtH-003D3t-17 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-130-31.hlrn.qwest.net (murgatroyd) [71.211.130.31]:54170 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfM8ujtPRuo3C0tIRQYCJOmxqKKuBaQQpNRL4wmqeSjIn/WJdmyR7nn123L5OwTej9Kd6X7zO0bXr/RH4jaE7YjuslYFuxsi3nuKxyxL1nEmPpj1helI+ SJTgQoXnmkZfqmp2Q+SF3zWIlVrjQYVHbyrvP6lr75L5dHmDLZLdrJq/ufdlXq2iOeeBW2xOD3mO2Xed4BDlUmzRgefMmmqRK2U= X-Spam-Status: No, score=-3018.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> Bouhaouel, Mohamed via Gdb-patches writes: > I kindly request that you review this patch. Thank you for the patch. >> +/* See breakpoint.h. */ >> + >> +watchpoint::~watchpoint () >> +{ >> + /* Make sure to unlink the destroyed watchpoint from the related >> + breakpoint ring. */ >> + >> + breakpoint *bpt = this; >> + while (bpt->related_breakpoint != this) >> + bpt = bpt->related_breakpoint; >> + >> + bpt->related_breakpoint = this->related_breakpoint; It took me a while to understand this, but I guess it is just the same as the code in delete_breakpoint. I think this is ok. Approved-By: Tom Tromey Tom