From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 026563858C01 for ; Wed, 23 Aug 2023 08:52:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 026563858C01 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1692780747; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=P1DeNvfkotq6lHYfWa+aUP00N/s7BddQypfI4ddIH1Y=; b=Tpp4/QgjnJ2/Iuycx6a+McUYJG2JijGZ4dstnvrLIpEpf2TUBWmjobdcQ5VKjb3HeHYjDm KLh+vXqQAMoXdZCn1LIhqokBaie1bBrtZmYQiDhFiSe2KqBuJQ45bgmPi1tQZ0ZLU7kdjA BwOeTp0fjwkdxozWQzVtdMEoVKxCpag= Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-277-kNdTs0czOPSzfOdNeLq38Q-1; Wed, 23 Aug 2023 04:52:26 -0400 X-MC-Unique: kNdTs0czOPSzfOdNeLq38Q-1 Received: by mail-ed1-f69.google.com with SMTP id 4fb4d7f45d1cf-52a1ce52ad4so2060353a12.0 for ; Wed, 23 Aug 2023 01:52:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692780745; x=1693385545; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=P1DeNvfkotq6lHYfWa+aUP00N/s7BddQypfI4ddIH1Y=; b=Dy2orEiIpCpEpeSs+7hg14RmqKKU3S48yvUKFuEw3Bm/784e7ib4rzD0OMuOBEpM6R KG49Ue8NTRhw/mEd8WcwGVSohzqVPGRJtzbgpCEGqkyz22dgIQJSJtQnl0pi+WA/KAqC uz/qR8Hp12kej1zesFPvk+g6gFzuHzMJelbxx1uciHDZOj8i5zkJTSLGpWUPwzXpw2dm iskjv8DJUkCSXmozmDs7lWhHjyV2CxOGbuYb6H7O47zLcmy4imff693UCl9CpQqp8Wn5 z8bqNq7orw0EuKwimNHuRzmE+eGwyqAcGvt3TXR7Ps72HS/TmXQ+TCGKqAjQumBym+07 PpmQ== X-Gm-Message-State: AOJu0Yycib7+mBzhr12balHcFIaSNutQIzaXnGoKDMMhofOZya8vwVh3 o9F69zg3ZJpPP6Jj77jIgMsVjy/qNKggU9OP008wRkP0ysLFGvKnORav8V6gg6ypScnFBEz5VV6 cEpbpH6MVcKjTtYTmU91lBH0GaWbi4FOV9wNxxNpPy2jDQ+PuIRlm+kUWt+XI9W/6GmgL5VUe2Q Vol31WEw== X-Received: by 2002:a05:6402:34cf:b0:51d:b184:efd with SMTP id w15-20020a05640234cf00b0051db1840efdmr12999084edc.20.1692780745090; Wed, 23 Aug 2023 01:52:25 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGi4P7fEhQu70IVD9ZXsXvgDHhBZ/iWWEF6a2neykyuiyJIjnFksy6yh1kRdZrA+GTniKMRIQ== X-Received: by 2002:a05:6402:34cf:b0:51d:b184:efd with SMTP id w15-20020a05640234cf00b0051db1840efdmr12999072edc.20.1692780744768; Wed, 23 Aug 2023 01:52:24 -0700 (PDT) Received: from localhost ([31.111.84.232]) by smtp.gmail.com with ESMTPSA id f13-20020a056402004d00b005236410a16bsm9072530edu.35.2023.08.23.01.52.23 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Aug 2023 01:52:24 -0700 (PDT) From: Andrew Burgess To: gdb-patches@sourceware.org Cc: Subject: Re: [PATCH 0/3] New gdb::make_unique and more std::unique_ptr use In-Reply-To: <87fs4bw0pk.fsf@tromey.com> References: <87fs4bw0pk.fsf@tromey.com> Date: Wed, 23 Aug 2023 09:52:23 +0100 Message-ID: <87lee2b0oo.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-5.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Tom Tromey writes: >>>>>> "Andrew" == Andrew Burgess via Gdb-patches writes: > > Andrew> This started while working on another series, in order to avoid > Andrew> calling 'new' directly, I really wanted a std::make_unique function -- > Andrew> but that's C++14, so not available for GDB right now. > > Andrew> So I added a gdb::make_unique, which should be equivalent to the C++14 > Andrew> function. > > Andrew> The last two commits are additional make_unique/unique_ptr changes, > Andrew> but target specific areas that needed slightly more refactoring. > > Thanks for doing this. I re-read the series & with your latest > make_unique patch, it looks good to me. > > FWIW I think the ::make approach was just a sort of minimal refactoring > at the time. Previously the constructor didn't do anything. > > Approved-By: Tom Tromey Pushed. Thanks, Andrew