From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x12c.google.com (mail-il1-x12c.google.com [IPv6:2607:f8b0:4864:20::12c]) by sourceware.org (Postfix) with ESMTPS id 2871A3858430 for ; Fri, 7 Jul 2023 19:55:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2871A3858430 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-il1-x12c.google.com with SMTP id e9e14a558f8ab-3456fda4ed1so9279075ab.0 for ; Fri, 07 Jul 2023 12:55:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1688759751; x=1691351751; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=0sxBODwE938Cnj7heBkPovPtopTAUxqiHwi5MjWU1u0=; b=iqNAZJQGusGcDjY7FEvmBDDy+BxviTevGuX8qRTNvsjixrog1mwVtbZjuiG7sTXxm0 Z7r5KKaQFt2JfAPwKcCgijIooB7+dC+aZL1RjF8zUo9XQ2dAaUx/BYt8h9BIPBIkbRDV cGAbapYxC/Ed/VIh1+ORlXM73C44Ot+hQcSw9s8AxVdmNW3T2sfCr/ON1hoTLWtir9/F X82Y251YT1LWRRu+nTg3v+1yNFHUbgn01TtyPt9ibr9YUy1LekkEPLeI0NE1XIcjFd/g bvg4sjN2sfDCA0N2zDpcAKy1VghmMf+VfFh3M+jB58O5fX03Au7mrHQKDrjV6sPHlYBk darQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688759751; x=1691351751; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=0sxBODwE938Cnj7heBkPovPtopTAUxqiHwi5MjWU1u0=; b=ARw0w+z2K89WY8TQMIx0O+ZbVvEsgVCJ/QUm0Cof0YdFTR/RQpzdpuVXdmNa9EXogB 6t/nNf5XffvU+HeqDU/3ms46COtDkseWbyZiebtX21DFNKUY8j0UggV+X/w0xdvMAool 1UOMhE1VAxCWRtKwqf4wy/K66VSND9sjqPNrACIIz8Xoj5Ytt5LMdybH9DTm2J2r7rYP zFlzalYEdNjqjEubl1Igbo436HxyvjkMcdqW3Kee6OLoX8Ak0z3Cp8YsI2DBUWpAcY0O x8T4jJgL7vCFoScSt3Y6lq6XjltHgEIbYz3+LNSoCgoNZcbNvDmUV8eT2lD31rZnKMGd R71Q== X-Gm-Message-State: ABy/qLYsMBfim4ijxJIkSKsoW3YaHbF0jXrxXJijH0wYmgfMbI/+ZSP6 zjKS77ler++d8mszDi8kW8oZww== X-Google-Smtp-Source: APBJJlHHsVuJHZdl3jsAL2G7MbVdT/ifndNYoQzjo1qg6B0ghSCO+Gs18jitBogIABZaWQkdmDlu3Q== X-Received: by 2002:a92:1a4e:0:b0:346:1185:31d0 with SMTP id z14-20020a921a4e000000b00346118531d0mr6289681ill.9.1688759751425; Fri, 07 Jul 2023 12:55:51 -0700 (PDT) Received: from murgatroyd (75-166-135-140.hlrn.qwest.net. [75.166.135.140]) by smtp.gmail.com with ESMTPSA id k12-20020a02cccc000000b0042b27413760sm1464474jaq.142.2023.07.07.12.55.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Jul 2023 12:55:50 -0700 (PDT) From: Tom Tromey To: Tom Tromey via Gdb-patches Cc: Tom Tromey , Simon Marchi Subject: Re: [PATCH] Remove unchecked casts to mi_interp References: <20230609161720.3677538-1-tromey@adacore.com> X-Attribution: Tom Date: Fri, 07 Jul 2023 13:55:49 -0600 In-Reply-To: <20230609161720.3677538-1-tromey@adacore.com> (Tom Tromey via Gdb-patches's message of "Fri, 9 Jun 2023 10:17:20 -0600") Message-ID: <87lefrsdh6.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Tom" == Tom Tromey via Gdb-patches writes: Tom> Simon noticed a crash that could be caused via new Python Tom> gdb.execute_mi function. Looking into this, I found a few unchecked Tom> casts to mi_interp, like: Tom> - struct mi_interp *mi = (struct mi_interp *) command_interp (); Tom> This patch replaces all such casts with safer variants. I'm checking this in. Tom