From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd2d.google.com (mail-io1-xd2d.google.com [IPv6:2607:f8b0:4864:20::d2d]) by sourceware.org (Postfix) with ESMTPS id A48763858D35 for ; Thu, 22 Jun 2023 16:09:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A48763858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-io1-xd2d.google.com with SMTP id ca18e2360f4ac-780d6e6b037so2968739f.3 for ; Thu, 22 Jun 2023 09:09:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1687450160; x=1690042160; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=iju+voazCmxSCDDWEvLVqSApHC2XkJsKahDGBBaPlYY=; b=N2zNLUSJOfp7RJBkDtqLOMKOLFmCRU1JChfYu8jv7EP2CtaQ6Pxe3hcaVg9LudXao2 lZUZQ7jxkQwVh7Jw+P7T7VOIJ3Rpqi1RwswIDHGqrDyTFGT6Dki3YjyJMS1mIBOaB9CC WRR2OOJhjpapnm2rswATvAulyUP/6TXP7yKSgNM6FC+oAxXSIPVsNdU6w1MbGnnlC47P uCK0cu9cxmsigtjBI+VHK9MO5B8ie/rxLtJ6SU+galVwHzqQMtrPGbgicjjMSr6IRG6l Tl8X9MJEc1wmH9qPeaRzHHwRMKu66Op4MB2NOmznrxvwzirRqwNzc1omKKkIVw9x6DWX QUWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687450160; x=1690042160; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=iju+voazCmxSCDDWEvLVqSApHC2XkJsKahDGBBaPlYY=; b=PyO8mEoe69bbuYU+rGYJut1GoQnUBeVDoN//IFkIu0ViBsJcYNBa3ORaQsv96siRfA C5Ia7GTqiaan4Sk5GKlS1oiNaqoEOx7YRCiDiT5GMKynrbBdG7FsnmhJ9P+j8ywMbhzh bwkz7jJUSpeTxEbn2jRj5GS4UxLTOzY/TDUT58i81njZKrq/dnRBvA/+i13zc4Izm+b3 kn6sJdY56ewvrfwzSbQ7quff+rC6/0rCKsgLEJpecFMjuRn6hBN/QYK+Ch/CyDP0q3Ym oKgx5IoqceT2DX1VSgBq/HfDP6M1DDlQ8Mc6PxU4KxlqLwU/rpWIBsRASUyLdKFDWEyP Yhnw== X-Gm-Message-State: AC+VfDzFWOO/MtgM0s6827xhPHr6qpqehWWreAY0/pe/WxQZFBOGwza8 SErWCw3f0NcW5gYCxI/fzXmbZkQTpXG+5RD4qQmiXA== X-Google-Smtp-Source: ACHHUZ5Lkrrek6JlmxgQU9Qzsv/VcC1UOhWrQqSgENKmNchMWX7nnjomdLtbPZ5tnbrxJEzLswjhOA== X-Received: by 2002:a5e:8509:0:b0:780:ca6d:9ff2 with SMTP id i9-20020a5e8509000000b00780ca6d9ff2mr2329038ioj.12.1687450159865; Thu, 22 Jun 2023 09:09:19 -0700 (PDT) Received: from murgatroyd (75-166-136-83.hlrn.qwest.net. [75.166.136.83]) by smtp.gmail.com with ESMTPSA id ed4-20020a056638290400b004266788f303sm1990861jab.114.2023.06.22.09.09.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Jun 2023 09:09:19 -0700 (PDT) From: Tom Tromey To: Tom Tromey via Gdb-patches Cc: Tom Tromey Subject: Re: [PATCH 4/5] Simplify FrameVars References: <20230614-dap-frame-decor-v1-0-af87db6467b2@adacore.com> <20230614-dap-frame-decor-v1-4-af87db6467b2@adacore.com> X-Attribution: Tom Date: Thu, 22 Jun 2023 10:09:18 -0600 In-Reply-To: <20230614-dap-frame-decor-v1-4-af87db6467b2@adacore.com> (Tom Tromey via Gdb-patches's message of "Wed, 14 Jun 2023 10:30:50 -0600") Message-ID: <87legb1ntd.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Tom" == Tom Tromey via Gdb-patches writes: Tom> FrameVars implements its own variant of Symbol.is_variable and/or Tom> Symbol.is_control. This patch replaces this code. Tom> - if self.fetch_b(sym): Tom> + if sym.is_variable or sym.is_constant: I found out that using is_constant here is wrong, as this picks up local enum constants, which aren't really interesting as variables. In v2 of the series I fix this, and I tack on a test case at the end of the series. Tom