From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 858323858C2D for ; Fri, 12 May 2023 17:43:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 858323858C2D Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1683913385; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=zRh8KfQ8/9kpmwjkKYW/aajuFQnZ7tUJErpLjiJ182g=; b=C+dchMZ+EWlWsVn7lhhUebILRJwPXnkP86WU3yAW6+7xxk5IMskVu0N7eYq/XuHCmtgxC5 peLZeSYC8h0Vc8oMvkXq20MXPAQN76VBDz8tiXJc436FLhQm81cpdL6/C608hEByDxPDLU u+ElzC+qdhQAqDgkh4Rpd+Fx3Jx0HfM= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-219-Ub5FoOV1NDqcwnBgbtnx1A-1; Fri, 12 May 2023 13:43:03 -0400 X-MC-Unique: Ub5FoOV1NDqcwnBgbtnx1A-1 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-30635d18e55so3608894f8f.2 for ; Fri, 12 May 2023 10:43:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683913382; x=1686505382; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=zRh8KfQ8/9kpmwjkKYW/aajuFQnZ7tUJErpLjiJ182g=; b=LhNVJWrsDZYjGkyTNc/CBaML3BqnmQaJ/+5LQzmbdbvSE0DVOx7zdJVv+muE0NWcLy AdiSSGiUSj46dszdZNs8ql6TDCa1KtsuiFzGseekKF4cE5Ky/JN5IOhD3V65SuA4/CEM dqyYzDP4wbxRdGgK5ZtOE9XcHX9N9MA3ls2LKh5321+ayqi5eTev9FPGa7fxNOuCHRQ7 y/pRVbjb0Xg+9VOQzny7TECvFgIQB+0BRl+pY0JS+jSCO9ONt/Q/l/ePZjShXku4w+um Pv07XccJHNGp1jMYLRNRVEBUxve+X0yiCmZCFftXtkHP5JVbkB8zqL9v/cGmslYGKmou Y9Zg== X-Gm-Message-State: AC+VfDybgx80Am6p9gINDTC3Rur8e++UUfrFMuEXS2WMBu2+XZpHevos UsBBJlldHY5csAsZvF8D0aNHDG3XZIRflRUTQsoOKDrG8reTHwvYw+AnuyfLNk35B19C4BxduLS 69BxfAoZ0dIJSvuJd27xkOw== X-Received: by 2002:a5d:4848:0:b0:306:3284:824f with SMTP id n8-20020a5d4848000000b003063284824fmr16042583wrs.8.1683913382364; Fri, 12 May 2023 10:43:02 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4XJ/7gaK23VE8sGVBhhxp/1IzIR+xA7TicKDMRezby5JKk0goNaagUzREubJz1Qnz9NWcF/A== X-Received: by 2002:a5d:4848:0:b0:306:3284:824f with SMTP id n8-20020a5d4848000000b003063284824fmr16042571wrs.8.1683913382068; Fri, 12 May 2023 10:43:02 -0700 (PDT) Received: from localhost (92.40.219.54.threembb.co.uk. [92.40.219.54]) by smtp.gmail.com with ESMTPSA id o2-20020a5d62c2000000b003062c609115sm23862422wrv.21.2023.05.12.10.43.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 May 2023 10:43:01 -0700 (PDT) From: Andrew Burgess To: Eli Zaretskii Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 1/5] gdb/doc: improve Python Disassembler API documentation In-Reply-To: <87fs8jaahp.fsf@redhat.com> References: <3cdddabce2d5acfbdb9a8c5bdcb1a205a2bd01e5.1680596378.git.aburgess@redhat.com> <83y1n7ubex.fsf@gnu.org> <87fs8jaahp.fsf@redhat.com> Date: Fri, 12 May 2023 18:42:59 +0100 Message-ID: <87leht5tuk.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Andrew Burgess writes: > Eli Zaretskii writes: > >>> Cc: Andrew Burgess >>> Date: Tue, 4 Apr 2023 09:21:03 +0100 >>> From: Andrew Burgess via Gdb-patches >>> >>> --- a/gdb/doc/python.texi >>> +++ b/gdb/doc/python.texi >>> @@ -6909,7 +6909,7 @@ >>> @code{RuntimeError} exception if it is invalid. >>> @end defun >>> >>> -@defun DisassembleInfo.__init__ (info) >>> +@defun DisassembleInfo.__init__ (@var{info}) >> >> You consistently rewrite the Texinfo source to use @var inside the >> argument lists of a @defun. I already asked why, as I don't think >> this is required. I don't think you replied. So once again: why are >> you doing this? what problems happen if you don't? > > This is an unfortunate consequence of me posting many patches in similar > areas of GDB. All of these landed on the list prior to you enlightening > me that @var is not needed -- it's not me ignoring you. > > I should have been more proactive in reviewing my in-flight patches for > this error to avoid wasting your time. > > This change will, of course, be removed from this patch. > > Thanks for your patience, > Andrew > >> >> Otherwise, this is fine. Thanks. >> >> Reviewed-By: Eli Zaretskii I've now pushed this patch. Thanks, Andrew