From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gproxy1-pub.mail.unifiedlayer.com (gproxy1-pub.mail.unifiedlayer.com [69.89.25.95]) by sourceware.org (Postfix) with ESMTPS id 0AAFE3856947 for ; Wed, 10 May 2023 15:20:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0AAFE3856947 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw14.mail.unifiedlayer.com (unknown [10.0.90.129]) by progateway3.mail.pro1.eigbox.com (Postfix) with ESMTP id 5A37F1003F4F0 for ; Wed, 10 May 2023 15:20:28 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id wlcCp86tYTHoywlcCpIFdE; Wed, 10 May 2023 15:20:28 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=bviJuGWi c=1 sm=1 tr=0 ts=645bb63c a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=P0xRbXHiH_UA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=nKHkdVECxb_6CTg4GQ0A:9 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=i9XDg4AIcAtFC+9C6pCNoo9gDOncgxxqLNGZXkK7BYQ=; b=EXuWpGVu40DW+GI+sxgoTS2Ydp GILDXAnmfQXGBUoZ2g8LBxPJyZfRSiWMzr2cKvQ764Qeft2ynh+NnY7kqmYkTsycEK2Y1Z1xGyL8i Qd2NEsL0toHKkLCIT4qIjDY0/; Received: from 71-211-191-82.hlrn.qwest.net ([71.211.191.82]:40008 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pwlcB-00254R-Uo; Wed, 10 May 2023 09:20:27 -0600 From: Tom Tromey To: Tom de Vries via Gdb-patches Cc: Tom de Vries , Tom Tromey Subject: Re: [PATCH] [gdb/tui] Add set tui hide-last-column on/off/auto References: <20230509132004.22669-1-tdevries@suse.de> X-Attribution: Tom Date: Wed, 10 May 2023 09:20:27 -0600 In-Reply-To: <20230509132004.22669-1-tdevries@suse.de> (Tom de Vries via Gdb-patches's message of "Tue, 9 May 2023 15:20:04 +0200") Message-ID: <87lehw5i2s.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.191.82 X-Source-L: No X-Exim-ID: 1pwlcB-00254R-Uo X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-191-82.hlrn.qwest.net (murgatroyd) [71.211.191.82]:40008 X-Source-Auth: tom+tromey.com X-Email-Count: 4 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3019.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Tom" == Tom de Vries via Gdb-patches writes: Tom> But it's different when we define TERM=ansi, because of the implications for Tom> the xenl flag: Tom> ... Tom> $ TERM=xterm tput xenl; echo $? Tom> 0 Tom> $ TERM=ansi tput xenl; echo $? Tom> 1 Tom> ... Tom> which stands for "eat newline glitch". I wonder if it's possible to also set TERMCAP to deal with this. Tom> At this point, we could just disregard this as a user problem, but there is an Tom> interest in having this TERM=ansi working somewhat. This is because the Tom> native TERM for our tuiterm terminal emulator is ansi, and it's worthwhile: Tom> - being able to compare behaviour in the tuiterm and an actual terminal Tom> emulator like konsole or gnome-terminal (which typically will have the Tom> glitch), as well as Tom> - playing around with the TUI and explore new scenarios with TUI running in a Tom> mode as close as possible to tuiterm to increase the likeliness that the Tom> scenario can be reproduced in the tuiterm. Another option would be to change the test suite to also have the glitch and to set 'TERM=xterm' or something. Tom> So, we expose the fix at user level using a "set tui hide-last-column Tom> on/off/auto", with auto behaving like this: Tom> ... Tom> $ TERM=xterm gdb -q -ex "show tui hide-last-column" Tom> TUI last column hiding is "auto; currently off". Tom> $ TERM=ansi gdb -q -ex "show tui hide-last-column" Tom> TUI last column hiding is "auto; currently on". Tom> ... Tom> and use "set tui hide-last-column off" in the testsuite. So IIUC, the idea here is that sometimes you may want to try out TERM=ansi interactively, even though your actual terminal is different. This of course causes problems because TERM doesn't match the capabilities of the actual terminal. So then this setting works around one bug that's exposed? If that's accurate, and you still want this setting, then perhaps it should be under "maint". Ordinary users should not be doing this kind of thing and, for all we know, there are other incompatibilities that we just haven't stumbled across yet. Tom