From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x131.google.com (mail-il1-x131.google.com [IPv6:2607:f8b0:4864:20::131]) by sourceware.org (Postfix) with ESMTPS id 33C1C3858D32 for ; Fri, 10 Mar 2023 16:56:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 33C1C3858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-il1-x131.google.com with SMTP id k9so3225224ilu.13 for ; Fri, 10 Mar 2023 08:56:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1678467413; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=S+Usy2bfdrhvL1vYDUIaf8HKzLWKooSnk4PkaJwKaWU=; b=I2Vjv97FNkxr5OWp1khVHH0SZVuEIlkUSxauCGh5afnGHCJ9+j3Wjl/xgAyaBmDElF uJI+zDtN8fIPiXyFaKN0dUWKdKZq7bUyEnK43x+z4IWMBMWM5TeJJBDoTDLIGGwwfnIt 6kLPQcbAHXVwisx0i0mMfO9Ytok8MHQL4v3EomkkTpc8LUwtUSf4KCavT8r1X7dX3Ty5 vM8Qw3Rkxz2Xsaj02osaW9mekdl4mrJsE4ZEArhN7zmHyh3Zw98dsG6iLP4lOqU54fb2 noGEQc82KwDjw5Bh+LKHhleBHyhDDFuouXiajpu9mOYN8XbPlqE2bsw19uJJfiYv8RzF Hbog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678467413; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=S+Usy2bfdrhvL1vYDUIaf8HKzLWKooSnk4PkaJwKaWU=; b=Eod0fAyL8Af9VRDuKC/UftFfn77DlwDjDZ3ir7OmXFllLNhAGU0ABKSc5KsKHX9HSi HIbCDERjjcc16OJMsKCUWgcTvsIPIYRjCi3RBZBFGBvsvKz4uEZzShy6gDlo4OXM8bU6 ryxGiDLafsYcu6nqBQDBgZ9VlYhAomjCNVPUsIgs5qMnrTpfxrU5d0sXR+wjq2fiWL5E gaQ2/TYHhNA4bmT5UMvGJgbl0z6v8ZYXzg84qQgdcwxKzRMnGcx01aLeAkr7Ti4rkVO6 7uu8zk1T/uKdiYo1cDGHi9xsb+yhLh1laW2Y5XL3l/ocmmGcJjut8e7lXHgQw8AN2GIl 5skg== X-Gm-Message-State: AO0yUKWwfSjGtUmykevCHw1FaI7E+Xffs1kiZ52uqhoszkm5n5LHfb7G KgNhuFDKnmAMFIiAu7t+XlLQJd9y3KDzPcLzcTI= X-Google-Smtp-Source: AK7set9yzNPfQE4k+KT8so6/O2mBBO7RF8alxmMSvitfC+6OYMixqK6C2D46rpDj0kucdqqz9o8t/g== X-Received: by 2002:a05:6e02:1d07:b0:318:1cff:5dfa with SMTP id i7-20020a056e021d0700b003181cff5dfamr21073928ila.18.1678467413445; Fri, 10 Mar 2023 08:56:53 -0800 (PST) Received: from murgatroyd (71-211-185-113.hlrn.qwest.net. [71.211.185.113]) by smtp.gmail.com with ESMTPSA id t9-20020a028789000000b003e8a17d7b1fsm116119jai.27.2023.03.10.08.56.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Mar 2023 08:56:53 -0800 (PST) From: Tom Tromey To: Tom de Vries Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH] Introduce rust_at_least helper proc References: <20230301202538.3291371-1-tromey@adacore.com> X-Attribution: Tom Date: Fri, 10 Mar 2023 09:56:52 -0700 In-Reply-To: (Tom de Vries's message of "Fri, 10 Mar 2023 17:20:54 +0100") Message-ID: <87lek4lf3f.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Tom" == Tom de Vries writes: Tom> just an idea, this could also be implemented without introducing a new Tom> proc, using proc version_compare, so instead of: Tom> ... Tom> require {rust_at_least 1 30} Tom> ... Tom> we'd do: Tom> ... Tom> require {version_compare [rust_compiler_version] >= {1 30 0}} Tom> ... Having the proc seems simpler on the whole. Changing the implementation seems ok though. Tom> I needed the additional 0 because my rustc version is: Tom> ... Tom> $ rustc --version Tom> rustc 1.67.1 (d5a82bbd2 2023-02-07) (built from a source tarball) Tom> ... Tom> and version_compare currently requires comparing version-lists with Tom> the same length, but I suppose we could also change that to just Tom> assume a 0. Maybe I'll change version_compare not to require equal-length lists. That seems fragile in a way, like what if rustc adds some extra '.'. Tom