From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gproxy1-pub.mail.unifiedlayer.com (gproxy1-pub.mail.unifiedlayer.com [69.89.25.95]) by sourceware.org (Postfix) with ESMTPS id 9C7003858D38 for ; Fri, 10 Mar 2023 14:43:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9C7003858D38 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw11.mail.unifiedlayer.com (unknown [10.0.90.126]) by progateway3.mail.pro1.eigbox.com (Postfix) with ESMTP id 710E110047DB2 for ; Fri, 10 Mar 2023 14:43:39 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id ady7p5QPzmEhRady7prJmC; Fri, 10 Mar 2023 14:43:39 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=ct9eL30i c=1 sm=1 tr=0 ts=640b421b a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=k__wU0fu6RkA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=6I5d2MoRAAAA:8 a=CCpqsmhAAAAA:8 a=zstS-IiYAAAA:8 a=bw3eVDVHUZyKtl5HZu8A:9 a=IjZwj45LgO3ly-622nXo:22 a=ul9cdbp4aOFLsgKbc677:22 a=4G6NA9xxw8l3yy4pmD5M:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=87qKp2upGGRNQcyeaS40id6F8NqDuVTnZim0hvEy97k=; b=iwWLF93zan6ENluygEQcMO5trl ulSdMdUUP/P1/mNlZh/36hNmARiA6KwcP6q09t3nnPWL8JtmOudjRezPPrVgeeguLiSwPo52jFsSA n+mgCUrPK5T1EhRFhJ3P41qp2; Received: from 71-211-185-113.hlrn.qwest.net ([71.211.185.113]:49454 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pady7-003e7C-63; Fri, 10 Mar 2023 07:43:39 -0700 From: Tom Tromey To: John Baldwin Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] PR gdb/30214: Prefer local include paths to system include paths References: <20230309212341.55302-1-jhb@FreeBSD.org> X-Attribution: Tom Date: Fri, 10 Mar 2023 07:43:37 -0700 In-Reply-To: <20230309212341.55302-1-jhb@FreeBSD.org> (John Baldwin's message of "Thu, 9 Mar 2023 13:23:41 -0800") Message-ID: <87lek4mzty.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.185.113 X-Source-L: No X-Exim-ID: 1pady7-003e7C-63 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-185-113.hlrn.qwest.net (murgatroyd) [71.211.185.113]:49454 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3020.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "John" == John Baldwin writes: John> Some systems may install binutils headers into a system location John> (e.g. /usr/local/include on FreeBSD) which may also include headers John> for other external packages used by GDB such as zlib or zstd. If a John> system include path such as /usr/local/include is added before local John> include paths to directories within a clone or release tarball, then John> headers from the external binutils package are used which can result John> in build failures if the external binutils package is out of sync with John> the version of GDB being built. It seems a little weird that configure would ever end up with -I/usr/local/include but maybe that's some pkg-config weirdness or maybe some platforms don't include that by default so it's needed. John> To fix, sort the include paths in INTERNAL_CFLAGS_BASE to add CFLAGS John> for "local" componenets before external components. Could you add this trailer to the commit message? Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=30214 Also I think it's fine to apply this to the gdb 13 branch. Reviewed-By: Tom Tromey thanks, Tom