From: Thiago Jung Bauermann <thiago.bauermann@linaro.org>
To: Simon Marchi <simon.marchi@efficios.com>
Cc: Andrew Burgess <aburgess@redhat.com>,
Thiago Jung Bauermann via Gdb-patches
<gdb-patches@sourceware.org>
Subject: Re: [PATCH v3 2/8] gdbserver: Add PID parameter to linux_get_auxv and linux_get_hwcap
Date: Wed, 01 Feb 2023 19:33:44 +0000 [thread overview]
Message-ID: <87lelhkwo7.fsf@linaro.org> (raw)
In-Reply-To: <f1951c6e-6456-afc7-9303-0e2386f74abf@efficios.com>
Simon Marchi <simon.marchi@efficios.com> writes:
>>> @@ -946,17 +946,16 @@ extern int have_ptrace_getregset;
>>> *VALP and return 1. If not found or if there is an error, return
>>> 0. */
>>>
>>> -int linux_get_auxv (int wordsize, CORE_ADDR match,
>>> - CORE_ADDR *valp);
>>> +int linux_get_auxv (int pid, int wordsize, CORE_ADDR match, CORE_ADDR *valp);
>>>
>>> /* Fetch the AT_HWCAP entry from the auxv vector, where entries are length
>>> WORDSIZE. If no entry was found, return zero. */
>>>
>>> -CORE_ADDR linux_get_hwcap (int wordsize);
>>> +CORE_ADDR linux_get_hwcap (int pid, int wordsize);
>>>
>>> /* Fetch the AT_HWCAP2 entry from the auxv vector, where entries are length
>>> WORDSIZE. If no entry was found, return zero. */
>>>
>>> -CORE_ADDR linux_get_hwcap2 (int wordsize);
>>> +CORE_ADDR linux_get_hwcap2 (int pid, int wordsize);
>>
>> Ideally the comment for these three functions would be updated to
>> mention the PID argument.
This is how I changed the comments. What do you think?
diff --git a/gdbserver/linux-low.h b/gdbserver/linux-low.h
index 221de85aa2ee..4f95a27808ba 100644
--- a/gdbserver/linux-low.h
+++ b/gdbserver/linux-low.h
@@ -941,20 +941,19 @@ bool thread_db_thread_handle (ptid_t ptid, gdb_byte **handle, int *handle_len);
extern int have_ptrace_getregset;
-/* Search for the value with type MATCH in the auxv vector with
- entries of length WORDSIZE bytes. If found, store the value in
- *VALP and return 1. If not found or if there is an error, return
- 0. */
+/* Search for the value with type MATCH in the auxv vector, with entries of
+ length WORDSIZE bytes, of process with PID. If found, store the value
+ in *VALP and return 1. If not found or if there is an error, return 0. */
int linux_get_auxv (int pid, int wordsize, CORE_ADDR match, CORE_ADDR *valp);
/* Fetch the AT_HWCAP entry from the auxv vector, where entries are length
- WORDSIZE. If no entry was found, return zero. */
+ WORDSIZE, of process with PID. If no entry was found, return zero. */
CORE_ADDR linux_get_hwcap (int pid, int wordsize);
/* Fetch the AT_HWCAP2 entry from the auxv vector, where entries are length
- WORDSIZE. If no entry was found, return zero. */
+ WORDSIZE, of process with PID. If no entry was found, return zero. */
CORE_ADDR linux_get_hwcap2 (int pid, int wordsize);
> I think the patch is OK to push after addressing this comment.
Thanks!
--
Thiago
next prev parent reply other threads:[~2023-02-01 19:33 UTC|newest]
Thread overview: 94+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-30 4:45 [PATCH v3 0/8] gdbserver improvements for AArch64 SVE support Thiago Jung Bauermann
2023-01-30 4:45 ` [PATCH v3 1/8] gdbserver: Add assert in find_register_by_number Thiago Jung Bauermann
2023-01-31 17:05 ` Simon Marchi
2023-01-31 19:49 ` Thiago Jung Bauermann
2023-02-01 15:43 ` Simon Marchi
2023-01-30 4:45 ` [PATCH v3 2/8] gdbserver: Add PID parameter to linux_get_auxv and linux_get_hwcap Thiago Jung Bauermann
2023-02-01 9:07 ` Luis Machado
2023-02-01 10:54 ` Andrew Burgess
2023-02-01 16:01 ` Simon Marchi
2023-02-01 19:33 ` Thiago Jung Bauermann [this message]
2023-02-01 19:53 ` Simon Marchi
2023-02-01 21:55 ` Thiago Jung Bauermann
2023-02-06 19:54 ` Pedro Alves
2023-02-06 20:16 ` Simon Marchi
2023-02-07 15:19 ` Pedro Alves
2023-02-07 21:47 ` Thiago Jung Bauermann
2023-02-09 1:31 ` Simon Marchi
2023-02-10 3:54 ` Thiago Jung Bauermann
2023-02-07 22:28 ` Thiago Jung Bauermann
2023-01-30 4:45 ` [PATCH v3 3/8] gdbserver/linux-aarch64: Factor out function to get aarch64_features Thiago Jung Bauermann
2023-02-01 8:59 ` Luis Machado
2023-02-01 16:04 ` Simon Marchi
2023-02-01 22:13 ` Thiago Jung Bauermann
2023-01-30 4:45 ` [PATCH v3 4/8] gdbserver/linux-aarch64: When thread stops, update its target description Thiago Jung Bauermann
2023-02-01 9:05 ` Luis Machado
2023-02-01 11:06 ` Andrew Burgess
2023-02-01 16:21 ` Simon Marchi
2023-02-01 16:32 ` Luis Machado
2023-02-02 2:54 ` Thiago Jung Bauermann
2023-02-02 3:47 ` Simon Marchi
2023-02-03 3:47 ` Thiago Jung Bauermann
2023-02-03 11:13 ` Luis Machado
2023-02-04 15:26 ` Thiago Jung Bauermann
2023-02-03 11:11 ` Luis Machado
2023-02-04 15:21 ` Thiago Jung Bauermann
2023-02-06 9:07 ` Luis Machado
2023-02-06 12:15 ` Thiago Jung Bauermann
2023-02-06 20:29 ` Pedro Alves
2023-02-07 8:11 ` Luis Machado
2023-02-07 14:39 ` Thiago Jung Bauermann
2023-02-03 10:57 ` Luis Machado
2023-02-04 6:18 ` Thiago Jung Bauermann
2023-02-06 20:26 ` Pedro Alves
2023-02-07 21:06 ` Thiago Jung Bauermann
2023-02-09 2:46 ` Simon Marchi
2023-02-10 3:29 ` Thiago Jung Bauermann
2023-02-10 14:56 ` Luis Machado
2023-02-10 15:04 ` Tom Tromey
2023-02-10 15:28 ` Luis Machado
2023-02-10 17:26 ` Thiago Jung Bauermann
2023-02-10 21:01 ` Simon Marchi
2023-01-30 4:45 ` [PATCH v3 5/8] gdbserver: Transmit target description ID in thread list and stop reply Thiago Jung Bauermann
2023-01-30 12:52 ` Eli Zaretskii
2023-01-30 14:05 ` Thiago Jung Bauermann
2023-02-01 9:39 ` Luis Machado
2023-02-01 12:07 ` Andrew Burgess
2023-02-01 13:03 ` Eli Zaretskii
2023-02-01 17:37 ` Simon Marchi
2023-02-02 20:36 ` Thiago Jung Bauermann
2023-02-02 20:56 ` Simon Marchi
2023-02-01 20:46 ` Simon Marchi
2023-02-02 21:43 ` Thiago Jung Bauermann
2023-02-01 14:51 ` Andrew Burgess
2023-02-01 17:03 ` Simon Marchi
2023-02-02 19:52 ` Thiago Jung Bauermann
2023-02-02 20:51 ` Simon Marchi
2023-02-03 2:44 ` Thiago Jung Bauermann
2023-02-03 16:29 ` Andrew Burgess
2023-02-04 6:08 ` Thiago Jung Bauermann
2023-02-03 11:22 ` Luis Machado
2023-02-03 12:50 ` Simon Marchi
2023-01-30 4:45 ` [PATCH v3 6/8] gdb/remote: Parse tdesc field in stop reply and threads list XML Thiago Jung Bauermann
2023-02-01 9:52 ` Luis Machado
2023-02-05 0:06 ` Thiago Jung Bauermann
2023-02-06 9:10 ` Luis Machado
2023-02-01 14:32 ` Andrew Burgess
2023-02-01 19:50 ` Simon Marchi
2023-02-01 20:16 ` Simon Marchi
2023-02-03 11:27 ` Luis Machado
2023-02-03 13:19 ` Simon Marchi
2023-02-03 16:33 ` Andrew Burgess
2023-01-30 4:45 ` [PATCH v3 7/8] gdb/aarch64: Detect vector length changes when debugging remotely Thiago Jung Bauermann
2023-02-01 9:58 ` Luis Machado
2023-02-01 15:26 ` Andrew Burgess
2023-02-01 20:20 ` Simon Marchi
2023-02-03 11:31 ` Luis Machado
2023-02-03 16:38 ` Andrew Burgess
2023-02-03 19:07 ` Simon Marchi
2023-01-30 4:45 ` [PATCH v3 8/8] gdb/testsuite: Add test to exercise multi-threaded AArch64 SVE inferiors Thiago Jung Bauermann
2023-02-01 10:10 ` Luis Machado
2023-02-06 19:11 ` [PATCH v3 0/8] gdbserver improvements for AArch64 SVE support Pedro Alves
2023-02-06 20:05 ` Simon Marchi
2023-02-06 21:06 ` Pedro Alves
2023-02-07 13:49 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lelhkwo7.fsf@linaro.org \
--to=thiago.bauermann@linaro.org \
--cc=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@efficios.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).