public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@adacore.com>
To: Pedro Alves <pedro@palves.net>
Cc: Tom Tromey <tromey@adacore.com>,  gdb-patches@sourceware.org
Subject: Re: [PATCH] Update the 'g' packet documentation
Date: Fri, 13 Jan 2023 11:58:20 -0700	[thread overview]
Message-ID: <87lem645yr.fsf@tromey.com> (raw)
In-Reply-To: <533a8893-c0b2-ec5a-fa11-f83bf98f4429@palves.net> (Pedro Alves's message of "Fri, 13 Jan 2023 12:09:21 +0000")

>> -When reading registers from a trace frame (@pxref{Analyze Collected
>> -Data,,Using the Collected Data}), the stub may also return a string of
>> +When reading registers, the stub may also return a string of
>> literal @samp{x}'s in place of the register data digits, to indicate
>> that the corresponding register has not been collected, thus its value
>> is unavailable.  For example, for an architecture with 4 registers of
>> 

Pedro> Here, the new text still uses "collected", but lost the reference to trace frames.
Pedro> It seems to me that that will result in people not knowing what "collected"
Pedro> means in this context.

Yeah, I wanted to get rid of the trace frame note, because it's
confusing -- 'x' can be sent any time, not just a trace frame.

Tom

  reply	other threads:[~2023-01-13 18:58 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-11 18:37 Tom Tromey
2023-01-11 19:56 ` Eli Zaretskii
2023-01-13 12:09 ` Pedro Alves
2023-01-13 18:58   ` Tom Tromey [this message]
2023-01-27 15:25     ` [PATCH v2] " Pedro Alves
2023-01-27 16:15       ` Eli Zaretskii
2023-01-30 21:15       ` Tom Tromey
2023-02-16 17:10         ` Pedro Alves
2023-02-16 18:16           ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lem645yr.fsf@tromey.com \
    --to=tromey@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=pedro@palves.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).