From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gproxy3-pub.mail.unifiedlayer.com (gproxy3-pub.mail.unifiedlayer.com [69.89.30.42]) by sourceware.org (Postfix) with ESMTPS id 3391D3898506 for ; Thu, 15 Dec 2022 19:28:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3391D3898506 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw14.mail.unifiedlayer.com (unknown [10.0.90.129]) by progateway5.mail.pro1.eigbox.com (Postfix) with ESMTP id 448431004A241 for ; Thu, 15 Dec 2022 19:28:06 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id 5ttmpxZhtXEB25ttmp68cg; Thu, 15 Dec 2022 19:28:06 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=Ab50o1bG c=1 sm=1 tr=0 ts=639b7546 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=sHyYjHe8cH0A:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=TkDAxPwePHwvmVxO8EkA:9 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=3nX9iFA26F/Gzwfpm2nLl86Cc0Aix6J1omp/pF+nt6Q=; b=RNLy7dP4MivKZfeRX1phiwB9xM 76d4Ut60IyS9NpaPimeCrqkQGEEnCgwlt2fDj0aO4KxNyCuwsvGLktsPhkpK3Xnrt5KMpJhez1hLt RZLWFGWDVxm3xcyF3iwRJPTfW; Received: from 97-122-76-186.hlrn.qwest.net ([97.122.76.186]:56990 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1p5ttl-003BPT-Ru; Thu, 15 Dec 2022 12:28:05 -0700 From: Tom Tromey To: Andrew Burgess via Gdb-patches Cc: Tom Tromey , Andrew Burgess Subject: Re: [PATCH 2/2] gdb: fix crash when getting the value of a label symbol References: <9ec9a8db6a02169c4b18248f131715c54811550a.1671013621.git.aburgess@redhat.com> <87cz8mdkno.fsf@tromey.com> <871qp023zi.fsf@redhat.com> X-Attribution: Tom Date: Thu, 15 Dec 2022 12:28:02 -0700 In-Reply-To: <871qp023zi.fsf@redhat.com> (Andrew Burgess via Gdb-patches's message of "Thu, 15 Dec 2022 13:25:37 +0000") Message-ID: <87len8cvr1.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.76.186 X-Source-L: No X-Exim-ID: 1p5ttl-003BPT-Ru X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-76-186.hlrn.qwest.net (murgatroyd) [97.122.76.186]:56990 X-Source-Auth: tom+tromey.com X-Email-Count: 3 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3022.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Andrew> How about I just change to use 'void *' now? Seems like a good idea to me. Andrew> How's this? I have one little nit. Andrew> + struct type *void_ptr_type Andrew> + = lookup_pointer_type (builtin_type (var->arch ())->builtin_void); I think this can use builtin_data_ptr. Tom