From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from progateway7-pub.mail.pro1.eigbox.com (gproxy5-pub.mail.unifiedlayer.com [67.222.38.55]) by sourceware.org (Postfix) with ESMTPS id 4D8B13856B66 for ; Wed, 14 Dec 2022 16:00:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4D8B13856B66 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw14.mail.unifiedlayer.com (unknown [10.0.90.129]) by progateway7.mail.pro1.eigbox.com (Postfix) with ESMTP id 05DA21004818A for ; Wed, 14 Dec 2022 15:59:48 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id 5UAdpfEa5XEB25UAdpnwui; Wed, 14 Dec 2022 15:59:48 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=Ab50o1bG c=1 sm=1 tr=0 ts=6399f2f4 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=sHyYjHe8cH0A:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=81doXoe5yrfMGmbcRWEA:9 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=43F193fFczF7bQCBkxYDgitxAS7HKzzljJpR2reCtR4=; b=Vn5Ajbxwn07CqYOUbNL/qYl9X9 9Cjmr7mw9qMlsJ15z/yD7P3vtR0rrkk1tSo95asSkn4H6pZFR+0fsRSGh8KTKbHjourDOyNrR7c2I hnM686edW23QPFIjtgLSaMq2Q; Received: from 97-122-76-186.hlrn.qwest.net ([97.122.76.186]:56974 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1p5UAd-002VjT-FF; Wed, 14 Dec 2022 08:59:47 -0700 From: Tom Tromey To: Jan Vrany via Gdb-patches Cc: Jan Vrany , tom@tromey.com, luis.machado@arm.com, simark@simark.ca Subject: Re: [PATCH] gdb: fix command lookup in execute_command () commands" References: <4dc13e01-2fd8-a63e-24f2-a1f7c7650d3b@simark.ca> <20221214110747.1150349-1-jan.vrany@labware.com> X-Attribution: Tom Date: Wed, 14 Dec 2022 08:59:44 -0700 In-Reply-To: <20221214110747.1150349-1-jan.vrany@labware.com> (Jan Vrany via Gdb-patches's message of "Wed, 14 Dec 2022 11:07:47 +0000") Message-ID: <87lenadlhr.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.76.186 X-Source-L: No X-Exim-ID: 1p5UAd-002VjT-FF X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-76-186.hlrn.qwest.net (murgatroyd) [97.122.76.186]:56974 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3022.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Simon> Here are the unexpected failures I saw: [...] Jan> Hmm. I do not see these failures. I applied the patch and ran the full test suite. I'm on x86-64 Fedora 34. I see two new FAILs but they are in thread tests and so I assume they are just the usual kind of racy test thing. I didn't see any of the failures that Simon reports. So, from my perspective your proposed patch seems fine. I don't think we need to back out the previous patch. Simon, could you maybe double-check your results somehow? Or pick one of the failures and try to see why it's happening? thanks, Tom