From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by sourceware.org (Postfix) with ESMTPS id AD5FA3858D38 for ; Mon, 7 Nov 2022 14:10:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org AD5FA3858D38 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com Received: from pps.filterd (m0246629.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 2A7DLGAi019438; Mon, 7 Nov 2022 14:10:47 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : references : date : in-reply-to : message-id : content-type : mime-version; s=corp-2022-7-12; bh=EqvfS2vwj2gfGN0EZeoa3uTr915h2FhtXNCeLiLsft0=; b=1u9e5Ci/aB7muXx3v5IBWMap0UdASencv7ViXrn725WuKmWkb8teAzHtGPahRIANuaaR 8ju93bxrYPJXftUWbvLotwh5NMBX1vQdH38lyzJPoh294taxuIlPdkZgNc8mJ9xQLNWN evtIVUsOt+Sq6/cP7U2jOFY44FSOaEWjb0e3LHQ1iLdLvwo3OqASnuKiDsCRsuurwJcu DLP8r6xwIfpnhE8X6fGjM0AJ7YlvJuOMf2KEsctxC155qb4Q/Z06Z5m5ckVbZkhu5HEV THT8fv2TXBSXYCFDn9ke859cVma5KSQnP/zGQnjzGI/wxTAFRdis0JvCICOjyvYis8NK Dg== Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta03.appoci.oracle.com [130.35.103.27]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3kngrekwc0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 07 Nov 2022 14:10:46 +0000 Received: from pps.filterd (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 2A7DhspW038956; Mon, 7 Nov 2022 14:10:45 GMT Received: from nam02-sn1-obe.outbound.protection.outlook.com (mail-sn1anam02lp2047.outbound.protection.outlook.com [104.47.57.47]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3kpcqeuygr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 07 Nov 2022 14:10:45 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VVR4OxqS1aWXTo6c3Hh2k/KTmT+nXRbtJJnuEzk0ui06YZ08a87o7nlCkUyg+HzDSD00AJCQUWCPV7glwLXmM+zW2nWpVU09DU5n/qJB+xjKLubhBLrxY+zRv+6qtAoNyEh1vLOcep6VthqqNxvLgp0C3eUr+iU1Vo0cGW6Se1cQLweqxlnxQF/ERKHR5zpnaGd2Eo80PtZkuOMHpXBv8xASX+OlT9E6d/itss8kvuAwT3iSpkC4aYZF719LBSOQ0odXyAcJxGsn5ohy4W6IUTZM+BVh1WDW7J6/jFQl5NJzqcJ4DhEh3EiJfxxoTeF6v1sbvtAXSnD4CatHjf3wSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EqvfS2vwj2gfGN0EZeoa3uTr915h2FhtXNCeLiLsft0=; b=MFT1e+vsZzyB/IHlztTI2sSKucg7MDxhZuVRwk+XxkQpQfpcr8OiFZsKCXFM3vddsEYvIAcv1XFVMkMcGwErUQKHpVseUQGmCkbniqK6o+wxqbLoawZswrktPuXI5/tm+RNhf+thd+her9onyph350fLYVxz+pOGtrcD8/8I6hYDmiOorERQ6bC0SCbNCXNRki45pwyewrpEQzBogMRR2pfd8xFR+u3P9r+iJDPH95UOtAUWURs7ycfJLMh7LWjZPWQdu3SSC32JChK+TC9F7QyKl8QvznBoCpBstlFT/o0DUM+ForYH+/6yfeh44umzoX2SVs0/tr3MP8YLd9GyHw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EqvfS2vwj2gfGN0EZeoa3uTr915h2FhtXNCeLiLsft0=; b=dqCH4DxaJIbr9BPWX6Oy/loL7u06lXrg6SE1Zf7npGovNEofbSdViBaTXnmyCzDm3Qbr8Kk06c38S31sE888+nIt3nosbHFXpmdjwnnoJH/vd7ADicC8Fnq8EZpsLCbFOOeBumkeDHavc9aC8E53JqIdnsfl+NmR1HtZ/wo+Kss= Received: from BYAPR10MB2888.namprd10.prod.outlook.com (2603:10b6:a03:88::32) by IA0PR10MB6890.namprd10.prod.outlook.com (2603:10b6:208:432::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.25; Mon, 7 Nov 2022 14:10:42 +0000 Received: from BYAPR10MB2888.namprd10.prod.outlook.com ([fe80::5095:b148:8def:1049]) by BYAPR10MB2888.namprd10.prod.outlook.com ([fe80::5095:b148:8def:1049%5]) with mapi id 15.20.5791.026; Mon, 7 Nov 2022 14:10:42 +0000 From: "Jose E. Marchesi" To: Simon Marchi Cc: gdb-patches@sourceware.org, indu.bhagat@oracle.com, elena.zannoni@oracle.com Subject: Re: [PATCH V3] gdb: link executables with libtool References: <20221106131041.1221924-1-jose.marchesi@oracle.com> Date: Mon, 07 Nov 2022 15:14:39 +0100 In-Reply-To: (Simon Marchi's message of "Mon, 7 Nov 2022 08:26:48 -0500") Message-ID: <87leomam28.fsf@oracle.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Content-Type: text/plain X-ClientProxiedBy: AM0PR04CA0061.eurprd04.prod.outlook.com (2603:10a6:208:1::38) To BYAPR10MB2888.namprd10.prod.outlook.com (2603:10b6:a03:88::32) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR10MB2888:EE_|IA0PR10MB6890:EE_ X-MS-Office365-Filtering-Correlation-Id: 0eb0e0e0-da5e-4db9-01a2-08dac0c9db3b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: fnyxE33eKYRhcOQ9sIpG7zMU0zWU7IhXg2JlJK1hpb6Vtbvq3S6XLOo4Bg40WqKoxNc+++6b2m60J1JpWfwrIbh+V01WGlrgkbOzGq/4YKcBqa258/wiivJmQGVLLFovMtHQV2o/4j3m5NzQZTaavP3BPdEcvc158ZLsRmC1h/d+mrMvJj1WnIvbdi9RbGBhjN6lx9iqT4QVg9OvxjA//kOM+eZEyQmB4uPTUP9RwkVRri9Gh26+O/vBuEyCwoHGgq5RA8Emk8D2Z2G5PHliplTSUkXxhZuZs0a5ysA30/KdZSp7DFUUu+eymeE93AnlbCjPw0QLNM3rcxOiYH+x8UjwClpXjXeDSfe68VA7hqtYeAt37qo7sz6yf8MPIspWZ3vx9S0jx8FbHSP15KQUrv1aQsYp6+uMFBY39xWoLepkqTTFsQaGR6jGUNV2qXUoMWeYtvOvk+RchMozQR/C2+ybOnrzO2s0gofArpf+6Sesgxzo3h6njev1ejL8usQ8JrEv3yxsUbjyrc7ywzxQNUmoXtl+nhlXFIAhzKZzcdPR92nbymeCpAq1a3JgzJV8CCa6qq1Udgsvf1ELDr3PsvFvQeU7sHjqRpPLVw+JeUVLxFKK15AQrrhnzgFqa0rpCumW/gDyAKqvGarb5/vzTKjVFoIVx/MR5o+yqnYWcwhmidbWKIqnle7x/0MSkrPBoKI5o4HmDFjfJ12x6ACTPPLKtEyki9JRirCzXXxtR0fh7nFX7LLUVpZoebJKE/V4BvLXr6UsXrBdPiQ6fCRDg6aWF4ag7Q8hgPAXQP22gQDhxYuXzrbfiqYUuDyXfc5W3zHBNJ4+21n+nzGw+6pXog== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR10MB2888.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(136003)(39860400002)(396003)(346002)(366004)(451199015)(6486002)(966005)(478600001)(8936002)(5660300002)(36756003)(2906002)(316002)(6916009)(41300700001)(66476007)(66556008)(66946007)(8676002)(4326008)(83380400001)(6666004)(6506007)(107886003)(86362001)(6512007)(53546011)(26005)(2616005)(186003)(38100700002)(84970400001)(460985005);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?qwI5ocwEvBzL0ksSiwEvtylJOIiKMhRrxhCJUVD32HqDgsvbc56jDR3dFX88?= =?us-ascii?Q?ozv7FVQGa3kZdPP6n+DczYcCreo+yUUIfx1knhNW348AppaRmc7thZZYaGdt?= =?us-ascii?Q?VPLZIX4/m4zmUnGRQ6X8X9ECvswGN1symqb6T9sFTPXWx5KmDhRpGImSFviX?= =?us-ascii?Q?g3QqeOtrCN0lpsuOJgUMmWH9dxvPZmqmDyPqY98cBiRSOAro0/UjbQsL6XYh?= =?us-ascii?Q?MTAEor/iGn53oTw2Fz/4JKMYbU0fvRPhpcbG7DXsIuFAxa1l20Q4ZQ1fu+Aj?= =?us-ascii?Q?2cqZzWh1gZ0PqL+T6vZ10aXAZ2nRgFWIwGJiveZpUosEPRkDMXxvpJ1I0lIa?= =?us-ascii?Q?KMGwXgA8oAYhOYBfqAMM68KbfYuyKfrq4N9gc29Tln6S7UofPTSmZHRkA2iR?= =?us-ascii?Q?ZcOKgek7UEskJkTjWgczbnrbHXr2E8wFKWoyjbur2RRz33Zsmcn8NYHG3S1E?= =?us-ascii?Q?YRBmShv+EseBIthvhkT/pZAmxAJmKvyt0+SCaPGvSCp080KAD+/yeYQmn25k?= =?us-ascii?Q?vNSouL/+3O8OBDIuVhnViF0e2u40eEu3j3QiO2dIi5nHEC3B/8eigiLdMV3Z?= =?us-ascii?Q?sr69WDE6vvNwkr/i04QEfhVffdP3Dxkv4GZAVzm4X+Pv4vxdMxCOOmSKQWaG?= =?us-ascii?Q?nupsShM0uLWUUAVvQfSaoIz8IRCc4mGJrdbxm8Lgf3qU+ndhHju0iMTzivHD?= =?us-ascii?Q?72uSb2ugnemrdVSmKZ7LZUKvtbH042yxGJv0Q8D3Q8EIGH/huQSUYxal1qoW?= =?us-ascii?Q?7sUIlaiA2SoB2KoCkMnJrUorOcIxCTtkSsKuuK8MWFaYHphNBEC+FLRVATKI?= =?us-ascii?Q?fDiVJwYDewgOoMocOUHc/yrovtdXgonIsf3ztTaD3NdqPqEs7YMpDnSci436?= =?us-ascii?Q?R4tpKMqUdROYqLUNXR+CUOP6RJOxcp8UIMoVp5EeEJPXcRDlkWX4Is9GBmmQ?= =?us-ascii?Q?mj3xBTFRhjrviLpfHoZOfpBTr/cmBLltJfbIiacfYXA1xrPfELI4SJvIs+HG?= =?us-ascii?Q?FbEddXKpRqaHfKh0GYrdSqRGBUflBV1Db2nLHZLpE2RY/M8QpG+0SfwpyyFu?= =?us-ascii?Q?n4Kd2KTffwFciqrcHpYh1Vd0oKntvLFJ/ksqGeKmfEry6vrNH7Uzbd48xBo5?= =?us-ascii?Q?IQOkIJr5LziV4x9i/3E6j1sbrVpqL5cTYhbit94pYHnNOrKTW7Sf7n/dNNMR?= =?us-ascii?Q?pXkfK8c69vfiP6XnpeFjNNdxtWZTJ6R5lUtqvHoaRY5kD5v7s1ZPLk7ZSGaU?= =?us-ascii?Q?+T9B5tbszlJLMoQIFuO+3MEz5gLQ4LpVXfXeTegUVFH3u+Nd+pDAO/OsGqSn?= =?us-ascii?Q?Y349vKyAZV5bsLNMeyM6+t560ZO3gvrtLY8myksFMOvic4u0+RrVje7N/H7r?= =?us-ascii?Q?VPZ43sWprbrwd8Y+XvsnIE94IxOhA7MgwNgsIt4kYsaIV7i5Neh9C5MJHn63?= =?us-ascii?Q?np5YMyJeKRa429QXAMfIUJMXX3sj/4mCVlRJCfrepmTV1bgxaT+L1W7qHt9/?= =?us-ascii?Q?2zwagIXBuoekHRAwj5LKjWSpwEdEMq3B05609/z8b9wUyVXd2sdbydB3HWwB?= =?us-ascii?Q?TrQtNhHtVb41Nk7wbKBgDZ9nrBz3Nl+QSCmuMHSb+YjPOy/8K18gkz9xe3cs?= =?us-ascii?Q?0A=3D=3D?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0eb0e0e0-da5e-4db9-01a2-08dac0c9db3b X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB2888.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Nov 2022 14:10:42.8195 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: IH5zBC8ozuB6LicNafY5kMScl6Kiwrh1J15pEauiSoegtrJ8yvWIZfsGoUndUJ/elQ7gE869mozON44bdckdPNffMT2IWq8t95Ri1gjbzlI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR10MB6890 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-11-07_06,2022-11-07_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 adultscore=0 mlxscore=0 suspectscore=0 spamscore=0 malwarescore=0 bulkscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2210170000 definitions=main-2211070115 X-Proofpoint-ORIG-GUID: JThtWeJYt6SM5xtsgipQWXjF28Bnb4LX X-Proofpoint-GUID: JThtWeJYt6SM5xtsgipQWXjF28Bnb4LX X-Spam-Status: No, score=-6.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > On 11/6/22 08:10, Jose E. Marchesi via Gdb-patches wrote: >> [Changes from V2: >> - Add .. to AC_CONFIG_MACRO_DIRS so autoreconf DTRT. >> - Refer to libopcode as a libtool library. >> - Do not use libtool --mode=execute in testsuite/lib/gdb.exp. >> - Remove spurious entry from top-level ChangeLog. >> - Remove ChangeLog fragment from commit message. >> - Add git trailer to commit message. >> - Typos fixed in commit message.] >> >> This patch changes the GDB build system in order to use libtool to >> link the several built executables. This makes it possible to refer >> to libtool libraries (.la files) in CLIBS. >> >> As an application of the above, >> >> BFD now refers to ../libbfd/libbfd.la >> OPCODES now refers to ../opcodes/libopcodes.la >> LIBBACKTRACE_LIB now refers to ../libbacktrace/libbacktrace.la >> LIBCTF now refers to ../libctf/libctf.la >> >> NOTE1: The addition of libtool adds a few new configure-time options >> to GDB. Among these, --enable-shared and --disable-shared, which were >> previously ignored. Now GDB shall honor these options when linking, >> picking up the right version of the referred libtool libraries >> automagically. >> >> NOTE2: I have not tested the insight build. >> >> NOTE3: For regenerating configure I used an environment with Autoconf >> 2.69 and Automake 1.15.1. This should match the previously >> used version as announced in the configure script. >> >> NOTE4: Now the installed shared object libbfd.so is used by gdb >> if binutils is installed with --enable-shared. >> >> Testing performed: >> >> - --enable-shared and --disable-shared (the default in binutils) work >> as expected: the linked executables link with the archive or shared >> libraries transparently. >> >> - Makefile.in modified for EXEEXT = .exe. It installs the binaries >> just fine. The installed gdb.exe runs fine. >> >> - Native build regtested in x86_64. The installed gdb runs fine. >> >> In the regression testing I'm observing that the following tests >> doesn't seem to be deterministic: >> >> gdb.base/step-over-syscall.exp >> gdb.threads/process-dies-while-detaching.exp >> gdb.threads/process-dies-while-handling-bp.exp >> >> Sometimes some of the the tests in these files unexpectedly fail, >> like in: >> >> -PASS: gdb.threads/process-dies-while-detaching.exp: single-process: \ >> continue: detach: continue >> +FAIL: gdb.threads/process-dies-while-detaching.exp: single-process: \ >> continue: detach: continue >> >> Sometimes they unexpectedly pass: >> >> -KFAIL: gdb.base/step-over-syscall.exp: clone: displaced=on: \ >> check_pc_after_cross_syscall: single step over clone \ >> final pc (PRMS: gdb/19675) >> +PASS: gdb.base/step-over-syscall.exp: clone: displaced=on: \ >> check_pc_after_cross_syscall: single step over clone final pc >> >> -KFAIL: gdb.threads/process-dies-while-handling-bp.exp: \ >> non_stop=on: cond_bp_target=0: inferior 1 exited \ >> (prompt) (PRMS: gdb/18749) >> +PASS: gdb.threads/process-dies-while-handling-bp.exp: \ >> non_stop=on: cond_bp_target=0: inferior 1 exited >> >> - Cross build for aarch64-linux-gnu built to exercise >> program_transform_name and friends. The installed >> aarch64-linux-gnu-gdb runs fine. >> >> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=29372 >> --- >> gdb/Makefile.in | 14 +- >> gdb/aclocal.m4 | 5 + >> gdb/config.in | 4 + >> gdb/configure | 31544 ++++++++++++++++++++++++++++++--------------- >> gdb/configure.ac | 17 +- > > This diffstat claims there are changes to configure, but the patch > doesn't actually has them. Perhaps it's on purpose, because they are a > bit on the big side to send by email. I'd just like to double-check > that when I run autoreconf on my side, I get the same result as you. > Could you perhaps upload your patch to a git branch? It could be a user > branch here in the sourceware binutils-gdb repo. Yeah I removed the configure thunk because it is big. Just pushed the stuff to a branch users/jemarch/gdb-libtool.