From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id B0DB83858439 for ; Mon, 10 Oct 2022 12:05:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B0DB83858439 Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-408-at_fHNolNo-m9PuHwMmjWQ-1; Mon, 10 Oct 2022 08:05:07 -0400 X-MC-Unique: at_fHNolNo-m9PuHwMmjWQ-1 Received: by mail-wm1-f71.google.com with SMTP id d5-20020a05600c34c500b003b4fb42ccdeso8881631wmq.8 for ; Mon, 10 Oct 2022 05:05:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ddiEaTCmhsLtx4LN7ZlzLz7WdVNa/dJDcMWzOeuTPYg=; b=J62YK3ecPDTOoRUIIIod0BDMCjZAsZVN3CTJ9HQYBFey9UPvm8zvopZFHDq+ZgYqLY 1lP7+y0U+PmfuNIaiNh3qRnsM1zxIejct7+pxR54Vd0NAHJds7CPnPrW3BPmQLHhaZNa b7q/Xg4/4oZIsB5PULE4Cl1jDBiWr90lItHGUmbXcmSHJIRtMYp2yoVGcz0yfYP6bEEf PpDuFGaRhHgyhbhGEzbJTTUfGQyy+yNPWk7I3MWUGoEVft6aqXW2g8NKderj0ZVk/RV/ qOPjBFdGXvQj2gt/k2ysYlrI0f2qYIUVzBFddEBwT7dolMGeNTpdFow8eIknE8g154sK NeOA== X-Gm-Message-State: ACrzQf1SJgGy0+llwO0Fa7sgRH57RegCkg3clFJLgZnu6uareVK1EXMq Eq/6Xh0E0obZRR09Vh5RzVJawaYed2XzgISaU2QsqOnou/sa8qwJ6F4y3G/NcNOIj3fg+ofIL0Q qdivAJale3QIdM205So3xcA== X-Received: by 2002:adf:e0cb:0:b0:22e:2e7e:e57d with SMTP id m11-20020adfe0cb000000b0022e2e7ee57dmr11723047wri.170.1665403505696; Mon, 10 Oct 2022 05:05:05 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6PiAzOtWcfNcHk9t/zlszYvTu/ThCGCeyNoT+sglJqdS7Y+uQcppJ305DNlhmw+6q13xagKg== X-Received: by 2002:adf:e0cb:0:b0:22e:2e7e:e57d with SMTP id m11-20020adfe0cb000000b0022e2e7ee57dmr11723035wri.170.1665403505500; Mon, 10 Oct 2022 05:05:05 -0700 (PDT) Received: from localhost (52.72.115.87.dyn.plus.net. [87.115.72.52]) by smtp.gmail.com with ESMTPSA id i18-20020a5d5592000000b0021e51c039c5sm8815741wrv.80.2022.10.10.05.05.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Oct 2022 05:05:05 -0700 (PDT) From: Andrew Burgess To: Eli Zaretskii Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 3/3] gdb: add infcall specific debugging In-Reply-To: <83bkqoq2mk.fsf@gnu.org> References: <9871275a989ff2c262ea9c94e3172c7eabfe7957.1665076921.git.aburgess@redhat.com> <83bkqoq2mk.fsf@gnu.org> Date: Mon, 10 Oct 2022 13:05:04 +0100 Message-ID: <87lepnevf3.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-10.3 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Oct 2022 12:05:09 -0000 Eli Zaretskii writes: >> Date: Thu, 6 Oct 2022 18:23:45 +0100 >> From: Andrew Burgess via Gdb-patches >> >> diff --git a/gdb/NEWS b/gdb/NEWS >> index 796a4ef8072..8b519a648f7 100644 >> --- a/gdb/NEWS >> +++ b/gdb/NEWS >> @@ -111,6 +111,10 @@ maintenance print frame-id [ LEVEL ] >> Print GDB's internal frame-id for the frame at LEVEL. If LEVEL is >> not given, then print the frame-id for the currently selected frame. >> >> +set debug infcall on|off >> +show debug infcall >> + Print additional debug messages about inferior function calls. >> + > > This part is OK. > >> --- a/gdb/doc/gdb.texinfo >> +++ b/gdb/doc/gdb.texinfo >> @@ -27587,6 +27587,13 @@ >> @item show debug infrun >> Displays the current state of @value{GDBN} inferior debugging. >> >> +@item set debug infcall >> +@cindex inferior function call debugging info >> +Turns on or off display of debugging info related to when @value{GDBN} >> +makes inferior function calls. > > Is the "related to when" part accurate? It seems to imply that we > only display indications of such calls, whereas the code seems to do > much more: it shows detailed information about the call and its > results. So maybe reword as follows: > > Turns on or off display of debugging info related to inferior > function calls made by @value{GDBN}. Thanks for the feedback. I pushed this series with the fix you suggested. Thanks, Andrew