From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gproxy3-pub.mail.unifiedlayer.com (gproxy3-pub.mail.unifiedlayer.com [69.89.30.42]) by sourceware.org (Postfix) with ESMTPS id D7E7A3857B95 for ; Wed, 21 Sep 2022 16:44:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D7E7A3857B95 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw14.mail.unifiedlayer.com (unknown [10.0.90.129]) by progateway5.mail.pro1.eigbox.com (Postfix) with ESMTP id 5413E10045560 for ; Wed, 21 Sep 2022 16:44:15 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id b2paoqKf6lpGeb2pbodrg3; Wed, 21 Sep 2022 16:44:15 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=UZmU9IeN c=1 sm=1 tr=0 ts=632b3f5f a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=IkcTkHD0fZMA:10:nop_charset_1 a=xOM3xZuef0cA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=p_tJRnKuuKrXCkAG2LgA:9 a=QEXdDO2ut3YA:10:nop_charset_2 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID: In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=HxFgMFLxnVVwhHp2dAz3Qn3S6eW37FAMvsfpeHpzHPM=; b=BI60DTi5JSMPyK8joVkY4nqklb GiZRAbu5RbLXQJaYNp39v0mBR9pKqKTQ5fIT9CXxsAIXZ+xdP7aIgK5uqJf9yGwJ19p9yiK9NuoQm 3y76bKfZhfaZP7T55qQMgqOyU; Received: from 71-211-160-49.hlrn.qwest.net ([71.211.160.49]:56544 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1ob2pa-001O8b-2d; Wed, 21 Sep 2022 10:44:14 -0600 From: Tom Tromey To: Lancelot SIX via Gdb-patches Cc: Simon Marchi , Lancelot SIX Subject: Re: [PATCH 3/4] gdb: add type::length / type::set_length References: <20220916150836.527213-1-simon.marchi@efficios.com> <20220916150836.527213-3-simon.marchi@efficios.com> <20220921150144.s62znyu4ws356aro@ubuntu.lan> X-Attribution: Tom Date: Wed, 21 Sep 2022 10:44:08 -0600 In-Reply-To: <20220921150144.s62znyu4ws356aro@ubuntu.lan> (Lancelot SIX via Gdb-patches's message of "Wed, 21 Sep 2022 15:01:44 +0000") Message-ID: <87leqc3cfb.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.160.49 X-Source-L: No X-Exim-ID: 1ob2pa-001O8b-2d X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-160-49.hlrn.qwest.net (murgatroyd) [71.211.160.49]:56544 X-Source-Auth: tom+tromey.com X-Email-Count: 9 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3022.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Sep 2022 16:44:26 -0000 >>>>> "Lancelot" =3D=3D Lancelot SIX via Gdb-patches writes: >> - TYPE_LENGTH (array_type) =3D (array_bitsize + 7) / 8; >> + array_type->set_length ((array_bitsize + 7) / 8); Lancelot> Do you think that while at it you could also replace the 7 and 8 Lancelot> literals with appropriate configured values? ... Lancelot> =E2=80=AF / HOST_CHAR_BIT); Normally I think the '8' is a target value, not a host value. Like, if HOST_CHAR_BIT !=3D 8, would this do the wrong thing? Tom