From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x136.google.com (mail-il1-x136.google.com [IPv6:2607:f8b0:4864:20::136]) by sourceware.org (Postfix) with ESMTPS id B93393858413 for ; Wed, 3 Aug 2022 18:47:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B93393858413 Received: by mail-il1-x136.google.com with SMTP id d4so8912926ilc.8 for ; Wed, 03 Aug 2022 11:47:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc; bh=maK10QM4MwR/vzvRFJqY0niQwQzM5PEllKYYho2U0N0=; b=ETa4JtpAuJU4sDLQMI5LzBBOMYkzd29TYzsUovNJ9TP+MW9N0nlVt/9wGPZBPh0pAo 20SGroE3CuscOb1rpDCi/ojkttGjSMCDUXWwpCdJuUtZTa3AAOvRXN0iizTkevVNstOc 1AY/Qaw9kUQz390cLNjkNiVwN5l2i6IAiolGCHlPqRyzGpiZPMnBzDrK6HMGAdHJQFm2 x2CQRLHCu2IxU8fIuzqTGRqGusrs0QjLdYDB5PI0vt1rtigrjZ217U+VqM2Q9i5sV/vd 1RXvbtm2/E0noafp6dmRx5znrzVLVUtec/lWYhbEmO4vDDpSxjXIsE2A+mqZgiLZjiNH O56w== X-Gm-Message-State: ACgBeo2Ul8hKx/Al4+CkOyAimBVoduAm1XOuqRaeaBAMUg5ZCa/f5rMM ZcJSvaiuPI/ckYdto0fUiU0FjIYqTg1jPg== X-Google-Smtp-Source: AA6agR4jn1y/Zz6kg3ndM6q1yzC2O4aZ98LErubYMj0RL1+8vvcnMnO0Xy4L0HB/IxGN69yOaXK2UA== X-Received: by 2002:a05:6e02:1a63:b0:2df:3655:a661 with SMTP id w3-20020a056e021a6300b002df3655a661mr1094739ilv.187.1659552446040; Wed, 03 Aug 2022 11:47:26 -0700 (PDT) Received: from murgatroyd (71-211-185-228.hlrn.qwest.net. [71.211.185.228]) by smtp.gmail.com with ESMTPSA id cs1-20020a056638470100b00339db3266c7sm7927191jab.124.2022.08.03.11.47.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Aug 2022 11:47:25 -0700 (PDT) From: Tom Tromey To: Eli Zaretskii Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 1/2] Move some Windows operations to worker thread References: <20220803130822.735057-1-tromey@adacore.com> <20220803130822.735057-2-tromey@adacore.com> <83a68l5u4h.fsf@gnu.org> X-Attribution: Tom Date: Wed, 03 Aug 2022 12:47:24 -0600 In-Reply-To: <83a68l5u4h.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 03 Aug 2022 16:33:50 +0300") Message-ID: <87les5go5f.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Aug 2022 18:47:28 -0000 >> + HANDLE bg_thread = CreateThread (nullptr, 0, fn, this, 0, nullptr); Eli> That zero in the 2nd argument of CreateThread means the worker thread Eli> will get the same stack size as the value recorded in the GDB Eli> executable file's header, which is 12MB according to my reading of Eli> gdb/Makefile, at least in my build? That's unlikely to be required Eli> for this thread, so I suggest to specify a non-zero value there Eli> instead. I guess 64KB should be enough? I changed it to `64 * 1024` and re-tested, and this worked ok. Tom