From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gproxy3-pub.mail.unifiedlayer.com (gproxy3-pub.mail.unifiedlayer.com [69.89.30.42]) by sourceware.org (Postfix) with ESMTPS id 653D33857BBD for ; Fri, 15 Jul 2022 20:05:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 653D33857BBD Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw14.mail.unifiedlayer.com (unknown [10.0.90.129]) by progateway5.mail.pro1.eigbox.com (Postfix) with ESMTP id E029610048796 for ; Fri, 15 Jul 2022 20:05:14 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id CRYooLXU7Uff9CRYooobPJ; Fri, 15 Jul 2022 20:05:14 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=e7XD9Yl/ c=1 sm=1 tr=0 ts=62d1c87a a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=RgO8CyIxsXoA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=y9jaVSMG-1XowxwihO4A:9 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=INTG74y64QfBmrRoRjkEH1yhEfSl04Rzyufj1UpSiH0=; b=b13+rOCHLxc2qQM+6UL0R3N+TK 6FHbURtljYZtUZhd3/g/wEjMuCiflFAY8Lm8BgKFOGCgWH7Ih1Rai3MJyT8l9n62bFOoEhC77Ex/1 o0iWME4JJ8CXRC/N7iwvwJFGf; Received: from 71-211-185-228.hlrn.qwest.net ([71.211.185.228]:56136 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1oCRYo-000eJG-8h; Fri, 15 Jul 2022 14:05:14 -0600 From: Tom Tromey To: Nils-Christian Kempke via Gdb-patches Subject: Re: [PATCH 1/3] gdb: add support for DW_AT_trampoline in DWARF reader References: <20220707121538.1317473-2-nils-christian.kempke@intel.com> X-Attribution: Tom Date: Fri, 15 Jul 2022 14:05:13 -0600 In-Reply-To: <20220707121538.1317473-2-nils-christian.kempke@intel.com> (Nils-Christian Kempke via Gdb-patches's message of "Thu, 7 Jul 2022 14:15:36 +0200") Message-ID: <87lesum9ae.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.185.228 X-Source-L: No X-Exim-ID: 1oCRYo-000eJG-8h X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-185-228.hlrn.qwest.net (murgatroyd) [71.211.185.228]:56136 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3022.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Jul 2022 20:05:26 -0000 >>>>> Nils-Christian Kempke via Gdb-patches writes: > DW_AT_trampoline can be used to describe compiler generated functions > that serve some intermediary purpose on making a call to another > function. A compiler can emit this tag in order to help a debugger hide > the trampolines from a user. Thank you for the patch. > + const char* target_name = dwarf2_name (target_die, target_cu); "*" comes after the space. > + { > + CORE_ADDR target_addr = attr->as_address (); > + target_addr = gdbarch_adjust_dwarf2_addr (objfile->arch (), > + target_addr + baseaddr); > + TYPE_TRAMPOLINE_TARGET (ftype)->set_target_physaddr (target_addr); If a data structure holds an address that already has the section offset applied, then objfile_relocate1 must be updated to relocate the value. However, if you can possibly avoid adding the section offset, in favor of handling this when the address is used, then that is better IMO. thanks, Tom