From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id E0CC7385741C for ; Tue, 17 May 2022 10:47:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E0CC7385741C Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-379-UUM46IbfO_-sh_LmP35QoQ-1; Tue, 17 May 2022 06:47:13 -0400 X-MC-Unique: UUM46IbfO_-sh_LmP35QoQ-1 Received: by mail-wr1-f70.google.com with SMTP id bj22-20020a0560001e1600b0020cccc6b25aso4559757wrb.1 for ; Tue, 17 May 2022 03:47:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:in-reply-to:references:date :message-id:mime-version; bh=3lLpVnoxRsUT9ANjhFwjDx4whBgN0qwF/vrzGnmRsHM=; b=Sc0A6CBVxTV5cdM3+fqAGxiNFE/uyY0KnIc9KYvbiw1aA76RKi0yVxR0CzrzyKR6tm g3YtqL1aShErnqUfehULfGuspn0VYC0CrZLKQZvksHHmcv8QPK0QNRH4epCcYVLrcY3X 4Zf8WpACeRDWPyasC9/Zwq1ZmXsArjeqwkBIMU492uixsc75nh2oUhZQrTdv/6tYN1iv Ga6pAziGfC7RYUpI4z3K3X3WQN+v1gRC0ZjQaQDKITma2JZpI+NFirBHnthk62WyaJi3 WNeb+EFeWXTgdtce0V+fKcXD2syTcmwl+5y+RBLbqFUxKTn8TcAszaVn2LS7wwlb/YNa JBag== X-Gm-Message-State: AOAM533lS7uWdw+rzUEi+4T+m6GZy/dzlJjF5FriX1RttjGzRfXPBOpJ yzFPGz7sX5djdcKIX0y9WYvigrcKiA0Pht60d7tLW7OwYDl8Hinx+vTh4Or5m9YNFbB7arviiXR RCw9Ya+yck7nZ6W9OxYleHQ== X-Received: by 2002:adf:d1ea:0:b0:20c:505e:babc with SMTP id g10-20020adfd1ea000000b0020c505ebabcmr17737437wrd.562.1652784432177; Tue, 17 May 2022 03:47:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzotSUwvnCFnbtA+gpJQd9zn9gS5IPYI0jttHN8hxl75skggYjxrbjftSj0FT6AQHkBekUkAA== X-Received: by 2002:adf:d1ea:0:b0:20c:505e:babc with SMTP id g10-20020adfd1ea000000b0020c505ebabcmr17737426wrd.562.1652784431976; Tue, 17 May 2022 03:47:11 -0700 (PDT) Received: from localhost (host81-136-113-48.range81-136.btcentralplus.com. [81.136.113.48]) by smtp.gmail.com with ESMTPSA id j38-20020a05600c1c2600b00395f15d993fsm1541155wms.5.2022.05.17.03.47.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 May 2022 03:47:11 -0700 (PDT) From: Andrew Burgess To: "Willgerodt\, Felix" , "Metzger\, Markus T" , "gdb-patches\@sourceware.org" Subject: RE: [PATCH] gdb, btrace: Throw an error for empty recordings when replaying starts. In-Reply-To: References: <20220511080707.726213-1-felix.willgerodt@intel.com> <87ilqcl8gh.fsf@redhat.com> Date: Tue, 17 May 2022 11:47:10 +0100 Message-ID: <87lev0jv0x.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-12.2 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 May 2022 10:47:16 -0000 "Willgerodt, Felix via Gdb-patches" writes: >> -----Original Message----- >> From: Andrew Burgess >> Sent: Mittwoch, 11. Mai 2022 11:34 >> To: Willgerodt, Felix ; Metzger, Markus T >> ; gdb-patches@sourceware.org >> Subject: Re: [PATCH] gdb, btrace: Throw an error for empty recordings when >> replaying starts. >> >> Felix Willgerodt via Gdb-patches writes: >> >> > This makes record_btrace_start_replaying() more consistent, as it already >> > errors out e.g. on a recording with only gaps. >> > --- >> > gdb/record-btrace.c | 2 +- >> > 1 file changed, 1 insertion(+), 1 deletion(-) >> > >> > diff --git a/gdb/record-btrace.c b/gdb/record-btrace.c >> > index 373d82b8b99..3f8a69dd04f 100644 >> > --- a/gdb/record-btrace.c >> > +++ b/gdb/record-btrace.c >> > @@ -2017,7 +2017,7 @@ record_btrace_start_replaying (struct >> thread_info *tp) >> > >> > /* We can't start replaying without trace. */ >> > if (btinfo->functions.empty ()) >> > - return NULL; >> > + error (_("No trace.")); >> > >> > /* GDB stores the current frame_id when stepping in order to detects >> steps >> > into subroutines. >> >> Please can you add a test for this change. >> >> Thanks, >> Andrew > > Mhm, I don't think there is an actual test I can write to trigger this. > All callers prevent it from happening by checking btinfo->replay. I'd think an assert would be a better choice, but if you really prefer the error message then I'm not going to block the patch. Thanks, Andrew > I am just making it more consistent, as the function already > errors out in the case of just gaps. Another advantage is that this function > doesn't return NULL anymore, which seems better for future callers. > > Thanks, > Felix > Intel Deutschland GmbH > Registered Address: Am Campeon 10, 85579 Neubiberg, Germany > Tel: +49 89 99 8853-0, www.intel.de > Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva > Chairperson of the Supervisory Board: Nicole Lau > Registered Office: Munich > Commercial Register: Amtsgericht Muenchen HRB 186928