Re: [PATCH 03/36] Add an assertion to clone_momentary_breakpoint

[Thiago Jung Bauermann <thiago.bauermann@linaro.org>]

Hi Tom,

Great patch series! Just something that caught my eye:

Tom Tromey <tom@tromey.com> writes:

> This adds an assertion to clone_momentary_breakpoint.  This will
> eventually be removed, but in the meantime is is useful for helping
> convince oneself that momentary breakpoints will always use
> momentary_breakpoint_ops.  This understanding will help when cleaning
> up the code later.
> ---
>  gdb/breakpoint.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c
> index da9997f18d6..a0b8bd4e127 100644
> --- a/gdb/breakpoint.c
> +++ b/gdb/breakpoint.c
> @@ -7900,6 +7900,7 @@ clone_momentary_breakpoint (struct breakpoint *orig)
>    if (orig == NULL)
>      return NULL;
>  
> +  gdb_assert (orig->ops = &momentary_breakpoint_ops);

This needs to be ‘==’ rather than ‘=’. :-)

>    return momentary_breakpoint_from_master (orig, orig->type, orig->ops, 0);
>  }


-- 
Thiago