From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd31.google.com (mail-io1-xd31.google.com [IPv6:2607:f8b0:4864:20::d31]) by sourceware.org (Postfix) with ESMTPS id D283A3858C83 for ; Thu, 10 Mar 2022 17:11:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D283A3858C83 Received: by mail-io1-xd31.google.com with SMTP id s20so7215450iol.2 for ; Thu, 10 Mar 2022 09:11:13 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=ljivH+fdODrWcB7zUIqZ74BZpgFau5BeIHMIuFozUBo=; b=wk8+50DaCBVY6ZIBjqOrqfrgsGOohzdM0iIYoqOLR9XxY1teXFXrlwdsI1dyS6gBzx 3rGIauhqkhTfdV1sW4H28BRTcFsUESRbwcNBbNDjb9wRdI3WT2CvQIXG5ZYkVS61V0fb bH1Jtus6F5sunhSGyT1Wnqwnitwy6qiPg1PCYDNgthnMwyPsW4Avliz6tZHa1cRMBr8o ftyMYJDCnX6IL/GrLaEbxA4KrFHOZ4wceeUntUOVeul9g5Rb1fOXuNV2UxDQbGDaEHnh N/TwDppLoUAvT6RdMuLWh8AC/3uLXo6S3JAaOGxT2wNxf6+8G21ZRTCNIaNKEPqh+75J MmXw== X-Gm-Message-State: AOAM531TsWpvDJib++cPCQmjG8ne+Uey75BVWgXUG5YKcmoWMG5tgFjl 46lRSHBJHdfpO0+cB3ns41D5OMRCE2uDdg== X-Google-Smtp-Source: ABdhPJxpA4SJvvByjMAbF6NBTcjZYDS/q69JOGmwCSJAdvIAukxBfyBTBug1Rk5YVlLJwr/QPUrvrA== X-Received: by 2002:a05:6602:2a45:b0:648:b21c:6f49 with SMTP id k5-20020a0566022a4500b00648b21c6f49mr2029764iov.206.1646932273114; Thu, 10 Mar 2022 09:11:13 -0800 (PST) Received: from murgatroyd (75-166-141-253.hlrn.qwest.net. [75.166.141.253]) by smtp.gmail.com with ESMTPSA id a12-20020a92c70c000000b002c668d6ec39sm3007623ilp.53.2022.03.10.09.11.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Mar 2022 09:11:12 -0800 (PST) From: Tom Tromey To: Aaron Merey Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH] Simplify the ui-out progress API References: <20220304193015.1940131-1-tromey@adacore.com> X-Attribution: Tom Date: Thu, 10 Mar 2022 10:11:11 -0700 In-Reply-To: (Aaron Merey's message of "Mon, 7 Mar 2022 12:50:31 -0500") Message-ID: <87lexhohqo.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Mar 2022 17:11:15 -0000 >>>>> "Aaron" == Aaron Merey writes: Aaron> Hi Tom, Aaron> On Fri, Mar 4, 2022 at 2:30 PM Tom Tromey wrote: >> I noticed that 'progress' is a method on ui-out, but it seems to me >> that it would be better if the only API were via the progress_meter >> class. This patch makes this change, changing progress to be a method >> on the meter itself. Aaron> LGTM. I agree that it's better to use progress_meter for this API. This Aaron> change should be fine even if we were to implement progress handling Aaron> in a ui_out derived class. Thanks. I'm going to check this in now. Tom