public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Akbarkhon Variskhanov via Gdb-patches <gdb-patches@sourceware.org>
Cc: Akbarkhon Variskhanov <akbarkhon.variskhanov@gmail.com>
Subject: Re: [PATCH] gdb/gcore.in - Redirect error messages to stderr
Date: Wed, 09 Mar 2022 10:21:19 -0700	[thread overview]
Message-ID: <87lexjoxdc.fsf@tromey.com> (raw)
In-Reply-To: <CANeoM1GOyWdcH7r+MaX_s9JROq_cL-MviZCHTwZJ82YW+0=igA@mail.gmail.com> (Akbarkhon Variskhanov via Gdb-patches's message of "Sun, 6 Mar 2022 14:59:44 +0500")

>>>>> Akbarkhon Variskhanov via Gdb-patches <gdb-patches@sourceware.org> writes:

Hi.  Thank you for the patch.

It's customary to put some text in the commit message, not just in the
title.  I suppose it's fine to reword the title and use that.

>  then
> -    echo "usage:  @GCORE_TRANSFORM_NAME@ [-a] [-o prefix] pid1
> [pid2...pidN]"
> +    echo >&2 "usage:  @GCORE_TRANSFORM_NAME@ [-a] [-o prefix] pid1
> [pid2...pidN]"
>      exit 2

It looks like something mangled the email in transmission.

Tom

      reply	other threads:[~2022-03-09 17:21 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-06  9:59 Akbarkhon Variskhanov
2022-03-09 17:21 ` Tom Tromey [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lexjoxdc.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=akbarkhon.variskhanov@gmail.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).