From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 7EE383858D39 for ; Wed, 2 Mar 2022 17:59:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7EE383858D39 Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-318-2GHxUlHyNtKNzLjXr5f1Mg-1; Wed, 02 Mar 2022 12:59:55 -0500 X-MC-Unique: 2GHxUlHyNtKNzLjXr5f1Mg-1 Received: by mail-wm1-f69.google.com with SMTP id l2-20020a1ced02000000b0038482a47e7eso859998wmh.5 for ; Wed, 02 Mar 2022 09:59:54 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:in-reply-to:references:date :message-id:mime-version; bh=vdF5Bwc9Ahfln6gT/NVYHfbTpCAmDxkFpfteRZGSlW0=; b=bob7KysG8Af4DygYcCZ8FuD4rJKqXDQS65KaPCcdpdi+mDK9NDEGAWsvmeKLr9cJSm OmFVtJC2b9oKLty3IO4lnrdM70FfjroHxHAx6OOb0FE/QGoa7a1cC5znGI5D12M3ozWe uf7j7EmP0RDSXgEIHA+fdolHvXaUVc/CYN9Kh1b09vXg+q18JJhTCgz/mxrrum2RDlJX vj96zSOBZKEpY0g6Qgk1l1PiHjvLMSdVBy1luRQu+JPQwdB1FX4q4nBXDgNDbxeV2Lj6 Y5x8OFJ33BThjHevYFK8MFFBCVTRqia/w6lejKPZlTxtKLYDUlRxamzduRsbtWp6MoYQ gIhQ== X-Gm-Message-State: AOAM530SyhXWyM3XhuqhDzCoJUdMHkfqPQgbeFTFoK6h8gzgvFja1I8t lfDFIFKbmMfuiS552XGZmXbAhaCOnAFMcrR8+yiFsJp5vQqPeD4TcxdXV2JddiKkW7cWTis0LYK 4qcEzYIBBFEMeznYHTLDHdj326DbyiX/9bj7yQoojhzb8BBw7un8KaKT0KQpgzzrCKHbBAe/cyA == X-Received: by 2002:a5d:45ca:0:b0:1ea:9bf9:ce5a with SMTP id b10-20020a5d45ca000000b001ea9bf9ce5amr24107762wrs.620.1646243993737; Wed, 02 Mar 2022 09:59:53 -0800 (PST) X-Google-Smtp-Source: ABdhPJwP9JhynJgZZUjvsHO3RcrGStaUGmtRRN5HayhWayit5aKpT7/uzlZdZnmpgbKWC6xNAM9VLg== X-Received: by 2002:a5d:45ca:0:b0:1ea:9bf9:ce5a with SMTP id b10-20020a5d45ca000000b001ea9bf9ce5amr24107747wrs.620.1646243993472; Wed, 02 Mar 2022 09:59:53 -0800 (PST) Received: from localhost (host86-169-131-29.range86-169.btcentralplus.com. [86.169.131.29]) by smtp.gmail.com with ESMTPSA id z5-20020a05600c0a0500b0037bb8df81a2sm8531746wmp.13.2022.03.02.09.59.52 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Mar 2022 09:59:52 -0800 (PST) From: Andrew Burgess To: gdb-patches@sourceware.org Subject: Re: [PATCHv2 00/15] TUI changes, new winwidth command and resizing changes In-Reply-To: <875yp8cen5.fsf@redhat.com> References: <875yp8cen5.fsf@redhat.com> Date: Wed, 02 Mar 2022 17:59:51 +0000 Message-ID: <87lexsxmjs.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-6.2 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, KAM_SHORT, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Mar 2022 17:59:58 -0000 Ping! Thanks, Andrew Andrew Burgess writes: > Ping! > > Thanks, > Andrew > > > Andrew Burgess writes: > >> I pushed the first two patches from the v1 series, but the rest of >> that original series does need reviewing - those paches are included >> in v2 as patches 1 to 5. >> >> The remaining 10 patches in the v2 series mostly relate to changing >> how window resizing, and window layout occurs. >> >> The docs content in patches 1 and 5 of the v2 series is unchanged from >> v1, and was already reviewed, so no new docs review is required there. >> >> There is some new docs content in patch 6, but its pretty minor; a >> docs review is always welcome though. >> >> I'm hoping most of the changes in this series will be pretty >> non-controversial, the only patch which I think might be more of a >> personal taste issue is the very last one (left last for that reason). >> I'd suggest selecting the split layout, and then playing with window >> resizing to get a feel for the new behaviour. Feedback welcome. >> >> Thanks, >> Andrew >> >> --- >> >> Andrew Burgess (15): >> gdb: move some commands into the tui namespace >> gdb/tui: rename tui_layout_base::adjust_size to ::set_height >> gdb/tui: rename tui_layout_split:set_weights_from_heights >> gdb/testing/tui: add new functionality to tuiterm.exp >> gdb/tui: add new 'tui window width' command and 'winwidth' alias >> gdb/tui: add a tui debugging flag >> gdb/tui: add left_boxed_p and right_boxed_p member functions >> gdb/tui/testsuite: refactor new-layout.exp test >> gdb/tui: avoid fp exception when applying layouts >> gdb/tui: fairer distribution of excess space during apply >> gdb/tui: allow cmd window to change size in tui_layout_split::apply >> gdb/tui: support placing the cmd window into a horizontal layout >> gdb/testsuite: some additional tests in gdb.tui/scroll.exp >> gdb/tui: relax restrictions on window max height and width >> gdb/tui: fair split of delta after a resize >> >> gdb/NEWS | 25 ++ >> gdb/doc/gdb.texinfo | 41 ++- >> gdb/testsuite/gdb.tui/basic.exp | 4 +- >> gdb/testsuite/gdb.tui/empty.exp | 14 +- >> gdb/testsuite/gdb.tui/new-layout.exp | 100 +++++-- >> gdb/testsuite/gdb.tui/regs.exp | 4 +- >> gdb/testsuite/gdb.tui/scroll.exp | 4 + >> gdb/testsuite/gdb.tui/winheight.exp | 77 +++++ >> gdb/testsuite/gdb.tui/winwidth.exp | 63 ++++ >> gdb/testsuite/lib/tuiterm.exp | 82 +++++- >> gdb/tui/tui-command.c | 6 - >> gdb/tui/tui-command.h | 2 - >> gdb/tui/tui-layout.c | 419 +++++++++++++++++++++++---- >> gdb/tui/tui-layout.h | 201 ++++++++++++- >> gdb/tui/tui-win.c | 149 ++++++++-- >> gdb/tui/tui.c | 26 ++ >> gdb/tui/tui.h | 14 + >> 17 files changed, 1089 insertions(+), 142 deletions(-) >> create mode 100644 gdb/testsuite/gdb.tui/winwidth.exp >> >> -- >> 2.25.4