From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gateway36.websitewelcome.com (gateway36.websitewelcome.com [192.185.194.2]) by sourceware.org (Postfix) with ESMTPS id A8456385842F for ; Wed, 1 Dec 2021 16:45:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A8456385842F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tromey.com Received: from cm16.websitewelcome.com (cm16.websitewelcome.com [100.42.49.19]) by gateway36.websitewelcome.com (Postfix) with ESMTP id 90FA140361BCF for ; Wed, 1 Dec 2021 10:44:38 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id sSSEmdX18L3b1sST6ml64e; Wed, 01 Dec 2021 10:29:17 -0600 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=rGzlt12E/tL+ucMAKjsngIg+B3ZbqudgEa26T1trOlY=; b=XZF/j+3a1xvj7bS6tqnt01Cz4M aBFU+W8I3v42Iw/AeSRNLXniIn3I8Sh/cO497ocOdbs8/F3i/EKaVy7gtW87DAjzebRUeFcG3UZ9z 3pTzkThQiS7KWKu1Eot6yCVIq; Received: from 97-122-84-67.hlrn.qwest.net ([97.122.84.67]:54236 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1msSS6-003MKy-Tx; Wed, 01 Dec 2021 09:27:26 -0700 From: Tom Tromey To: Aaron Merey via Gdb-patches Cc: Aaron Merey , Tom de Vries Subject: Re: [PATCH] [PR gdb/27026] CTRL-C is ignored when debug info is downloaded References: <20211124014314.217675-1-amerey@redhat.com> X-Attribution: Tom Date: Wed, 01 Dec 2021 09:27:26 -0700 In-Reply-To: <20211124014314.217675-1-amerey@redhat.com> (Aaron Merey via Gdb-patches's message of "Tue, 23 Nov 2021 20:43:14 -0500") Message-ID: <87lf1470k1.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.84.67 X-Source-L: No X-Exim-ID: 1msSS6-003MKy-Tx X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-84-67.hlrn.qwest.net (murgatroyd) [97.122.84.67]:54236 X-Source-Auth: tom+tromey.com X-Email-Count: 4 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3025.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_NEUTRAL, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Dec 2021 16:45:34 -0000 >>>>> "Aaron" == Aaron Merey via Gdb-patches writes: Aaron> + gdb::optional term_state; Aaron> + if (target_supports_terminal_ours ()) Aaron> + { Aaron> + term_state.emplace (); Aaron> + target_terminal::ours (); Aaron> + } I was curious to know if the gdb::optional and the target_supports_terminal_ours checks are really needed here. I think plenty of spots do this stuff unconditionally, so I was wondering if this code has some special need. Tom