From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd2b.google.com (mail-io1-xd2b.google.com [IPv6:2607:f8b0:4864:20::d2b]) by sourceware.org (Postfix) with ESMTPS id B46E63858D35 for ; Thu, 23 Sep 2021 14:10:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B46E63858D35 Received: by mail-io1-xd2b.google.com with SMTP id n71so8329747iod.0 for ; Thu, 23 Sep 2021 07:10:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=w3wCoeWR7wpFboSOG6jRWiLFIc2jLXWiCMx0fc/FwyQ=; b=4xykEyQMK2D8o02WZuUAb6khoqZdtXtOiQuGT0ubxJEJfAMbFLqYAzhO6pwIaPVtiU 6SU+MGE+zMsiwdQP+UQxvPRkOt/BKMcSr/6nR+Uo84dr0AQWKMxvQYxUDrGBDk8BDqnr qtqoO+OCUG7shw0bLqQSxDkHLkZChXsPQVpot29YfVeGoR5BQH+n3BgwfyMaEYPUP7Ws 9cK9NhnIb0Mj2iH9IueTYYsxhnnbzhelrI2io1BjNLtIadGi0qFb2kLw9wCMbEQ/ha6f fEMYqazMBLfpoIL6B7eUiKj4IUFbKXI5xeARbud48RcZjhXb5ztGfcA2UUiLRB5KSI8I FqqA== X-Gm-Message-State: AOAM530dzWfKARVNOjUy7KgIo7SdiWdQWA4+Xoi3u1O80qvQ0W3HqzIc fKi9zdZemQSGcAlVhidOAx7QyC3qyiz+lOQo X-Google-Smtp-Source: ABdhPJzULcu6T6GW15usGOX3Ig0jyCPYRf9XdMWM6bAH9l6tYks2NOteVVbQx7taAjkhRV3JlQb6hg== X-Received: by 2002:a05:6638:16d4:: with SMTP id g20mr4208535jat.22.1632406213315; Thu, 23 Sep 2021 07:10:13 -0700 (PDT) Received: from murgatroyd (174-16-0-219.hlrn.qwest.net. [174.16.0.219]) by smtp.gmail.com with ESMTPSA id s5sm2418727iol.33.2021.09.23.07.10.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Sep 2021 07:10:12 -0700 (PDT) From: Tom Tromey To: Andrew Burgess Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 2/3] Change ptid_t::tid to ULONGEST References: <20210922171055.2755900-1-tromey@adacore.com> <20210922171055.2755900-3-tromey@adacore.com> <20210923103104.GH4950@embecosm.com> X-Attribution: Tom Date: Thu, 23 Sep 2021 08:10:11 -0600 In-Reply-To: <20210923103104.GH4950@embecosm.com> (Andrew Burgess's message of "Thu, 23 Sep 2021 11:31:04 +0100") Message-ID: <87lf3n5qnw.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Sep 2021 14:10:16 -0000 Andrew> As you're changing this anyway, I think it would be better to write: Andrew> infrun_debug_printf ("saving status %s for %s", Andrew> target_waitstatus_to_string (ws).c_str (), Andrew> tp->ptid.to_string ().c_str ()); Make sense, I made these changes. Tom