Re: [PATCH 1/5] Remove gdb/testsuite/configure

[Tom Tromey <tromey@adacore.com>]

>> Sure.  If anybody relies on being able to do this without using 'make',
>> there's already a 'read1' convenience target that can be used.
>> 
>> I'm going to check this in with this change.

Tom> Personally I'm fine with no longer supporting this.  But perhaps others
Tom> use READ1=1 in combination with some nonstandard make target?  I'm not sure.

There's no way to know.
We can restore the old behavior if you think that's worthwhile.

Tom> Anyway, if we decide to leave things as they are now, we should document
Tom> this in gdb/testsuite/README:
Tom> ...
Tom>  Examples:

Tom>          make -j10 check-read1 TESTS="*/paginate-*.exp"
Tom> -        make -j10 check READ1="1"
Tom> ...

How about the appended?

Tom

commit 6bd42c74ef9b1838c9a0151fb089188de4b80e5f
Author: Tom Tromey <tromey@adacore.com>
Date:   Wed Jun 9 08:34:47 2021 -0600

    Update read1 example in gdb/testsuite/README
    
    Tom de Vries noticed that the recent changes to the testsuite's
    configury required an update to the README.  This patch changes the
    text to document the new reality.
    
    gdb/testsuite/ChangeLog
    2021-06-09  Tom Tromey  <tromey@adacore.com>
    
            * README (Example): Update read1 example.

diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index 92894d6efab..bd06a4433fd 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,3 +1,7 @@
+2021-06-09  Tom Tromey  <tromey@adacore.com>
+
+	* README (Example): Update read1 example.
+
 2021-06-08  Lancelot Six  <lsix@lancelotsix.com>
 
 	* gdb.base/premature-dummy-frame-removal.py (TestUnwinder): Use
diff --git a/gdb/testsuite/README b/gdb/testsuite/README
index 0036753eff0..862f423a988 100644
--- a/gdb/testsuite/README
+++ b/gdb/testsuite/README
@@ -347,9 +347,13 @@ return at most 1 byte.
 To enable this, either pass a non-empty value in the READ1 make
 variable, or use the check-read1 make target instead of check.
 
-Examples:
+Example:
 
 	make -j10 check-read1 TESTS="*/paginate-*.exp"
+
+If you've already built the read1 support code, either via a previous
+'check-read1' run, or by using "make read1", you can use:
+
 	make -j10 check READ1="1"
 
 Note: While the intention is to detect races and make otherwise passing tests