Re: [PATCH 2/2] Add system includes in sim

[Tom Tromey <tom@tromey.com>]

>>>>> "Mike" == Mike Frysinger <vapier@gentoo.org> writes:

Mike> On 08 Apr 2021 12:32, Tom Tromey wrote:
>> >> * func.c: Include sys/time.h.
>> 
Mike> this one isn't in C99.  we seem to sometimes protect against it, but not
Mike> always.  if we go by gnulib's notes, it seems like we should just assume
Mike> it everywhere.  wdyt ?
Mike> https://www.gnu.org/software/gnulib/manual/html_node/sys_002ftime_002eh.html#sys_002ftime_002eh
>> 
>> Makes sense to me.
>> 
>> Also, BFD removed the check for time.h, among other things, in commit
>> 83c79df86.  If BFD can remove it, I think it's fine.

Mike> we removed time.h checks in 68ed2854284d415a71efd856a40343f550881ede in sim
Mike> since it's in C99.  this question is about sys/time.h which is different.

Sorry, I meant to say sys/time.h there.
The BFD ChangeLog says:

	* configure.ac: Don't check for long long or long double type.
	Don't check for alloca.h, limits.h, stddef.h, stdlib.h, string.h,
	strings.h, time.h, wchar.h, wctype.h or sys/time.h.  [...]

So I still think it's fine.

Tom