From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gateway21.websitewelcome.com (gateway21.websitewelcome.com [192.185.45.163]) by sourceware.org (Postfix) with ESMTPS id 6CA893954836 for ; Thu, 8 Apr 2021 19:30:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 6CA893954836 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm13.websitewelcome.com (cm13.websitewelcome.com [100.42.49.6]) by gateway21.websitewelcome.com (Postfix) with ESMTP id 0CE0C400FCD38 for ; Thu, 8 Apr 2021 14:30:19 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id UaM6lKyu0mJLsUaM6lrf1D; Thu, 08 Apr 2021 14:30:19 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=k4z9hdvC9qXnTVdLcXJBwKJkkMXVj3j/PTG+uOY6sY8=; b=fxnH5E+TAEA+rcDqccnC3KODLQ lt3ovVVB05fFRbwy8J7gE/SY7SSt/7BNxKmNijYnJ8LKCN8IDOgAIJ++pN47p21xCGDztWqv0S729 bxurExl7Ifn6kfEaFSesjD2mZ; Received: from 71-211-182-15.hlrn.qwest.net ([71.211.182.15]:53290 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1lUaM6-0049B8-J7; Thu, 08 Apr 2021 13:30:18 -0600 From: Tom Tromey To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 2/2] Add system includes in sim References: <20210408164436.2165323-1-tom@tromey.com> <20210408164436.2165323-3-tom@tromey.com> <87y2dsk4og.fsf@tromey.com> X-Attribution: Tom Date: Thu, 08 Apr 2021 13:30:17 -0600 In-Reply-To: (Mike Frysinger's message of "Thu, 8 Apr 2021 15:26:03 -0400") Message-ID: <87lf9sk20m.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.182.15 X-Source-L: No X-Exim-ID: 1lUaM6-0049B8-J7 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-182-15.hlrn.qwest.net (murgatroyd) [71.211.182.15]:53290 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3020.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, KAM_SHORT, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_BL_SPAMCOP_NET, RCVD_IN_DNSWL_NONE, RCVD_IN_SBL_CSS, SPF_HELO_PASS, SPF_NEUTRAL, TXREP, URIBL_CSS, URIBL_CSS_A autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Apr 2021 19:30:31 -0000 >>>>> "Mike" == Mike Frysinger writes: Mike> On 08 Apr 2021 12:32, Tom Tromey wrote: >> >> * func.c: Include sys/time.h. >> Mike> this one isn't in C99. we seem to sometimes protect against it, but not Mike> always. if we go by gnulib's notes, it seems like we should just assume Mike> it everywhere. wdyt ? Mike> https://www.gnu.org/software/gnulib/manual/html_node/sys_002ftime_002eh.html#sys_002ftime_002eh >> >> Makes sense to me. >> >> Also, BFD removed the check for time.h, among other things, in commit >> 83c79df86. If BFD can remove it, I think it's fine. Mike> we removed time.h checks in 68ed2854284d415a71efd856a40343f550881ede in sim Mike> since it's in C99. this question is about sys/time.h which is different. Sorry, I meant to say sys/time.h there. The BFD ChangeLog says: * configure.ac: Don't check for long long or long double type. Don't check for alloca.h, limits.h, stddef.h, stdlib.h, string.h, strings.h, time.h, wchar.h, wctype.h or sys/time.h. [...] So I still think it's fine. Tom