From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gateway23.websitewelcome.com (gateway23.websitewelcome.com [192.185.50.141]) by sourceware.org (Postfix) with ESMTPS id 46510385782C for ; Mon, 15 Mar 2021 19:41:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 46510385782C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm10.websitewelcome.com (cm10.websitewelcome.com [100.42.49.4]) by gateway23.websitewelcome.com (Postfix) with ESMTP id D987FC1C2 for ; Mon, 15 Mar 2021 14:41:00 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id Lt5Ils87tkscSLt5Illmpg; Mon, 15 Mar 2021 14:41:00 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=4uigQWmu1JW6nxQe5jmO2rm78OQVwAppPP6hmnU00DE=; b=jMhgvKhgU+1ji38t5JHwJf5zQr TQWL7ImgMpUYudaZpG1GtWJrJXzIUWbeyC8LtWyTpSNSZ56bjsUZgvIRBMt/b06DG1ewApcTrA1ZF O7yPjmSoP+kUiwHWlg5kDRwik; Received: from 71-211-137-228.hlrn.qwest.net ([71.211.137.228]:35130 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1lLt5I-0043ZB-BE; Mon, 15 Mar 2021 13:41:00 -0600 From: Tom Tromey To: "Tomar, Sourabh Singh via Gdb-patches" Cc: Tom Tromey , "Tomar, Sourabh Singh" , "George, Jini Susan" , "Achra, Nitika" , "Sharma, Alok Kumar" , "E, Nagajyothi" , "Kumar N, Bhuvanendra" Subject: Re: [PATCH] [gdb.base] Enable macro test for clang compiler References: <878s6u965g.fsf@tromey.com> <87a6r84g15.fsf@tromey.com> X-Attribution: Tom Date: Mon, 15 Mar 2021 13:40:59 -0600 In-Reply-To: (Sourabh Singh via Gdb-patches Tomar's message of "Mon, 15 Mar 2021 05:51:39 +0000") Message-ID: <87lfao19ys.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.137.228 X-Source-L: No X-Exim-ID: 1lLt5I-0043ZB-BE X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-137-228.hlrn.qwest.net (murgatroyd) [71.211.137.228]:35130 X-Source-Auth: tom+tromey.com X-Email-Count: 5 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3022.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_BL_SPAMCOP_NET, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_NEUTRAL, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Mar 2021 19:41:02 -0000 >>>>> ">" == Tomar, Sourabh Singh via Gdb-patches writes: >> Apologies missed the attachment/patch. No worries. >> Updated ChangeLog: >> 2021-03-15 Sourabh Singh Tomar >> * gdb.base/info-macros.exp: Append -fdebug-macro to >> additional_flags for clang. >> * gdb.base/macscp.exp: Likewise. >> * gdb.base/style.exp: Likewise. >> * gdb.linespec/macro-relative.exp: Likewise. This is ok with one minor tweak. If you have write access (I didn't look) you can just fix it up and check it in. >> +if {[test_compiler_info gcc*]} { >> # Don't use "debug" here. Otherwise "-g" would be appended to the gcc >> # command line, possibly overriding "-g3" (depending on gcc version). >> set options "additional_flags=-g3" >> +} elseif {[test_compiler_info clang*]} { >> +set options "additional_flags=-fdebug-macro" >> +} else { >> + untested "no compiler info" >> + return -1 >> +} The body of the if/elseif/else blocks should be indented. For Tcl, GDB uses a 4 space indent. thanks, Tom