public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Tom Tromey <tom@tromey.com>
Cc: Andrew Burgess <andrew.burgess@embecosm.com>,
	 gdb-patches@sourceware.org
Subject: Re: [PATCHv2 2/2] gdb/fortran: Access elements of a structure with dynamic type
Date: Sun, 26 Jul 2020 13:31:54 -0600	[thread overview]
Message-ID: <87lfj6oyxh.fsf@tromey.com> (raw)
In-Reply-To: <87mu3obrz7.fsf@tromey.com> (Tom Tromey's message of "Fri, 24 Jul 2020 14:03:40 -0600")

Tom> Also, I think the implementation currently relies on this to
Tom> handle type inference for expressions like "x ? a : b" -- where the
Tom> types of both "a" and "b" affect the result.

This part isn't true.  Maybe I was remembering something I'd planned to
do, not sure.

However, in some cases EVAL_AVOID_SIDE_EFFECTS really is needed.
For example it's needed to properly implement sizeof(), which doesn't
evaluate its argument.

Tom> In fact, the whole expression data structure and evaluator needs to
Tom> be rewritten.  It's awful as-is.  It's a big job though.

I looked at it a bit this weekend and it is even bigger than I
remembered.  In addition to the data structure and the parsers, the Ada
parser has a resolution pass to rewrite the expression in-place (even, I
think, asking the user questions); the agent expression code translates
expressions to bytecode; and there's another pass that looks to see if
an expression refers to a given objfile.

Tom

  reply	other threads:[~2020-07-26 19:31 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-10 15:22 [PATCH 0/2] Fortran dynamic type related fixes Andrew Burgess
2020-07-10 15:22 ` [PATCH 1/2] gdb/fortran: resolve dynamic types when readjusting after an indirection Andrew Burgess
2020-07-10 15:22 ` [PATCH 2/2] gdb/fortran: Access elements of a structure with dynamic type Andrew Burgess
2020-07-13 13:33 ` [PATCHv2 0/2] Fortran dynamic type related fixes Andrew Burgess
2020-07-13 13:33   ` [PATCHv2 1/2] gdb/fortran: resolve dynamic types when readjusting after an indirection Andrew Burgess
2020-07-22 19:10     ` Tom Tromey
2020-07-25  0:31       ` Andrew Burgess
2020-07-13 13:33   ` [PATCHv2 2/2] gdb/fortran: Access elements of a structure with dynamic type Andrew Burgess
2020-07-22 19:19     ` Tom Tromey
2020-07-23 10:28       ` Andrew Burgess
2020-07-24 20:03         ` Tom Tromey
2020-07-26 19:31           ` Tom Tromey [this message]
2020-08-04 19:19           ` Tom Tromey
2020-08-06 15:38             ` Andrew Burgess

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lfj6oyxh.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=andrew.burgess@embecosm.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).