From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gateway36.websitewelcome.com (gateway36.websitewelcome.com [192.185.188.18]) by sourceware.org (Postfix) with ESMTPS id B8328386F800 for ; Tue, 19 May 2020 18:18:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org B8328386F800 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm14.websitewelcome.com (cm14.websitewelcome.com [100.42.49.7]) by gateway36.websitewelcome.com (Postfix) with ESMTP id 97A90400F5EBB for ; Tue, 19 May 2020 12:37:59 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id b6oxjNrIMXVkQb6oyjTfxj; Tue, 19 May 2020 13:18:32 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=dPLnJyP9QTIbipykfWZl2f6OqZmrvwejkejp3P2Fshs=; b=ml7+n9fbMApl9/3iIoI8fEHuQj EQGVu8J/2YLFaouNDFXbO0/XTo0sfF8cJ0OBsGs2SG0cqZNy6/m7ASyr/pgIWsfFI6j5UxcxdyMbV 73IXGp+1TZ23O50CGYG9RizXR; Received: from 174-16-104-48.hlrn.qwest.net ([174.16.104.48]:54382 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1jb6ox-003lcL-NR; Tue, 19 May 2020 12:18:31 -0600 From: Tom Tromey To: Simon Marchi via Gdb-patches Cc: Simon Marchi Subject: Re: [PATCH] gdb: fix off-by-one error in quirk_rust_enum References: <20200519181557.1625215-1-simon.marchi@efficios.com> X-Attribution: Tom Date: Tue, 19 May 2020 12:18:30 -0600 In-Reply-To: <20200519181557.1625215-1-simon.marchi@efficios.com> (Simon Marchi via Gdb-patches's message of "Tue, 19 May 2020 14:15:57 -0400") Message-ID: <87lfln7pqh.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 174.16.104.48 X-Source-L: No X-Exim-ID: 1jb6ox-003lcL-NR X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 174-16-104-48.hlrn.qwest.net (murgatroyd) [174.16.104.48]:54382 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-1.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_NEUTRAL, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 May 2020 18:18:34 -0000 >>>>> "Simon" == Simon Marchi via Gdb-patches writes: Simon> Found by inspection, so I don't have a test for it (I don't think it Simon> would be easy to have this bug cause a failure reliably). Simon> We allocate space for N fields into `new_fields`, then memcpy N fields Simon> at `new_fields + 1`. This overflows the allocated buffer by one field. Simon> Fix it by allocating `N + 1` fields. Simon> gdb/ChangeLog: Simon> * dwarf2/read.c (quirk_rust_enum): Allocate enough fields. Looks good. Thank you. Tom