From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gateway33.websitewelcome.com (gateway33.websitewelcome.com [192.185.146.80]) by sourceware.org (Postfix) with ESMTPS id CEED6387700A for ; Thu, 12 Mar 2020 17:58:58 +0000 (GMT) Received: from cm12.websitewelcome.com (cm12.websitewelcome.com [100.42.49.8]) by gateway33.websitewelcome.com (Postfix) with ESMTP id 2D2B6B73630 for ; Thu, 12 Mar 2020 12:58:56 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id CS6ij1ekg1s2xCS6ijlK9P; Thu, 12 Mar 2020 12:58:56 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=d8q15Yrak/b7wzaXHM8ck91VhiTXvyJeBWrtPKaCGN4=; b=W6h53arbXPFFGbD4QyT+uqCVwU ARDZ1OLoS2iZahZXpc0TxejR4bXuc8YkW4REDxzgs9hHqL1lfdSzd+vFkRFYZcsfkH+W/r/iZkBfp gGe7kf/moc17x1LVZjMJn5qld; Received: from 184-96-250-69.hlrn.qwest.net ([184.96.250.69]:60394 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1jCS6i-001WOT-C2; Thu, 12 Mar 2020 11:58:56 -0600 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH v2 3/6] Cast to bfd_vma in arm-tdep.c References: <20200225222243.8260-1-tom@tromey.com> <20200225222243.8260-4-tom@tromey.com> X-Attribution: Tom Date: Thu, 12 Mar 2020 11:58:55 -0600 In-Reply-To: (Simon Marchi's message of "Tue, 10 Mar 2020 23:38:06 -0400") Message-ID: <87lfo5jvz4.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 184.96.250.69 X-Source-L: No X-Exim-ID: 1jCS6i-001WOT-C2 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 184-96-250-69.hlrn.qwest.net (murgatroyd) [184.96.250.69]:60394 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-26.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_NEUTRAL autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Mar 2020 17:59:00 -0000 Simon> Did you consider changing arm_mapping_symbol::value to be a Simon> CORE_ADDR? It would seem even simpler and safe to me. For some reason I thought this was harder, but I tried it and it is fine. Here's the updated patch. Tom commit a01a37e95dc6927020783184eff1c82660b1cbf5 Author: Tom Tromey Date: Tue Mar 10 16:09:37 2020 -0600 Cast to bfd_vma in arm-tdep.c Some arm-tdep.c data structures use a bfd_vma. A couple of spots will warn about an implicit narrowing cast when building a gdb where CORE_ADDR is 64-bit but bfd_vma is 32-bit. This patch silences these warnings by changing the types in question to CORE_ADDR. gdb/ChangeLog 2020-03-10 Tom Tromey * arm-tdep.c (struct arm_mapping_symbol) : Now a CORE_ADDR. (struct arm_exidx_entry) : Now a CORE_ADDR. diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 86bbcaaa39f..280cf03a6a6 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,9 @@ +2020-03-10 Tom Tromey + + * arm-tdep.c (struct arm_mapping_symbol) : Now a + CORE_ADDR. + (struct arm_exidx_entry) : Now a CORE_ADDR. + 2020-03-10 Tom Tromey * remote.c (remote_target::download_tracepoint) diff --git a/gdb/arm-tdep.c b/gdb/arm-tdep.c index 175c5b956e7..44c439a85f5 100644 --- a/gdb/arm-tdep.c +++ b/gdb/arm-tdep.c @@ -81,7 +81,7 @@ static bool arm_debug; struct arm_mapping_symbol { - bfd_vma value; + CORE_ADDR value; char type; bool operator< (const arm_mapping_symbol &other) const @@ -1986,7 +1986,7 @@ struct frame_unwind arm_prologue_unwind = { struct arm_exidx_entry { - bfd_vma addr; + CORE_ADDR addr; gdb_byte *entry; bool operator< (const arm_exidx_entry &other) const