From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 105774 invoked by alias); 24 Feb 2020 03:22:47 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 105749 invoked by uid 89); 24 Feb 2020 03:22:47 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-10.1 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_1,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=H*i:sk:87r1ykn, H*f:sk:87r1ykn X-HELO: gateway34.websitewelcome.com Received: from gateway34.websitewelcome.com (HELO gateway34.websitewelcome.com) (192.185.149.46) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 24 Feb 2020 03:22:46 +0000 Received: from cm16.websitewelcome.com (cm16.websitewelcome.com [100.42.49.19]) by gateway34.websitewelcome.com (Postfix) with ESMTP id CB1B820F84EA for ; Sun, 23 Feb 2020 21:22:44 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 64KSjDJrE8vkB64KSj8ytH; Sun, 23 Feb 2020 21:22:44 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Ycq5ESiQdMuQsP2JpdUVDX3L7egF+cNGlzZ4V68k+fY=; b=xuIwW8AnwBsSJ+Q0+zxlxqMm0j fHouOXuhtvsXEGGf/TBaMA8o1E13ta/hXhMvB2PQro3VpzmTKuQ/4xM6uXJX7aXAWMPtWj+8VlHu+ whVvkfciis0rt+o2LCT1jsm3L; Received: from 75-166-123-50.hlrn.qwest.net ([75.166.123.50]:46790 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1j64KS-003ffo-IT; Sun, 23 Feb 2020 20:22:44 -0700 From: Tom Tromey To: Tom Tromey Cc: Simon Marchi , gdb-patches@sourceware.org Subject: Re: [PATCH 00/14] Share DWARF partial symtabs between objfiles In-Reply-To: <87r1ykn0o7.fsf@tromey.com> (Tom Tromey's message of "Sun, 23 Feb 2020 20:07:04 -0700") References: <20200215165444.32653-1-tom@tromey.com> <87y2ss5019.fsf@tromey.com> <8b11c5f6-771f-69b5-c98c-94ced592132f@simark.ca> <87r1ykn0o7.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Date: Mon, 24 Feb 2020 03:22:00 -0000 Message-ID: <87lfosmzy4.fsf@tromey.com> MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2020-02/txt/msg00913.txt.bz2 Tom> Take a look at my branch, t/reorganize-dwarf-code-sharing-3. Tom> I rearranged it to move all the "unshared" stuff to the end, so there Tom> should be less to fix up (though I see now I neglected to move the baton Tom> patch earlier). I made this change, so now the branch looks like (order is reversed from how git send-email would send it): 0 eeeb07c1120 Share DWARF partial symtabs 1 597fab7df48 Move signatured_type::type to unshareable object 2 9ec85b37d88 Split type_unit_group 3 f4d2c85a250 Introduce dwarf2_enter_objfile and use it 4 afcc2a6d028 Remove symtab links from dwarf2_psymtab and dwarf2_per_cu_quick_data 5 11fad00951b Introduce dwarf2_unshareable and move die_type_hash 6 49fe37ffefb Add objfile member to DWARF batons 7 842794fd4d9 Add dwarf2_per_cu_data::index 8 cbf63c32179 Fix a memory leak and remove an unused member 9 fe38cf467e1 Add "objfile" parameter to two partial_symtab methods 10 e0e096e6956 Convert IS_TYPE_UNIT_GROUP to method 11 ad71f2eb272 Introduce dwarf2_per_objfile::obstack 12 4a127c55a71 Simplify setting of reading_partial_symbols Basically I think switching the sharing would start at patch #5, and then parts of patch #0 would be salvaged, but not most of the rest of patches #1-#5. Also I have another patch here that adds a subclass of partial_symtab for DWARF includes. I *think* this solves the need to wrap the compunit_symtab pointer in an optional<>, though it remains hard to be completely certain. I'll send that sometime soon, I think it could go in separately. Tom