From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 100233 invoked by alias); 9 Oct 2019 17:58:36 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 100225 invoked by uid 89); 9 Oct 2019 17:58:36 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-6.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=arnez@linux.ibm.com, sk:arnez@l, U*arnez, arnezlinuxibmcom X-HELO: gateway30.websitewelcome.com Received: from gateway30.websitewelcome.com (HELO gateway30.websitewelcome.com) (192.185.150.24) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 09 Oct 2019 17:58:35 +0000 Received: from cm14.websitewelcome.com (cm14.websitewelcome.com [100.42.49.7]) by gateway30.websitewelcome.com (Postfix) with ESMTP id C318416855 for ; Wed, 9 Oct 2019 12:58:33 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id IGELiwtYeBnGaIGELi5rCt; Wed, 09 Oct 2019 12:58:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=BQyxqggiXK0lKU2mq/7mXvzIa9qNdyVfCPcDLxfQXmw=; b=KLboIiC8mTKzUGSdbnuJ8m+jC/ tLt44Fd5MqtlM7Acix6ZeP4ehGT5MGceNMa6LaRBZqs+7elXveXe6DFWFOa/7x9LTBFLDb/owF4Tk JZLPPHfpd5ay+ufK0SyyCGiAu; Received: from 174-29-53-230.hlrn.qwest.net ([174.29.53.230]:58056 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1iIGEL-002MM8-Em; Wed, 09 Oct 2019 11:58:33 -0600 From: Tom Tromey To: Andreas Arnez Cc: gdb-patches@sourceware.org, Alan Hayward , Andrew Burgess Subject: Re: [PATCH] gdb/testsuite: Fix typos in infcall-nested-structs.c References: Date: Wed, 09 Oct 2019 17:58:00 -0000 In-Reply-To: (Andreas Arnez's message of "Tue, 08 Oct 2019 13:23:59 +0200") Message-ID: <87lfttdcmv.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-10/txt/msg00258.txt.bz2 >>>>> "Andreas" == Andreas Arnez writes: Andreas> Some of the comparison functions in infcall-nested-structs.c contain Andreas> redundant comparisons like a. == a. instead of Andreas> a. == b.. They were introduced with this commit: Andreas> 36eb4c5f9bbe6 - "infcall-nested-structs: Test up to five fields" Andreas> Fix the redundant comparisons. Andreas> gdb/testsuite/ChangeLog: Andreas> * gdb.base/infcall-nested-structs.c (cmp_struct_02_01) Andreas> (cmp_struct_02_02, cmp_struct_04_01, cmp_struct_04_02) Andreas> (cmp_struct_05_01, cmp_struct_static_02_01) Andreas> (cmp_struct_static_04_01, cmp_struct_static_06_01): Fix redundant Andreas> comparisons. Thank you. This looks reasonable to me. I think you could have put it in under the obvious rule, even. Tom