From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27463 invoked by alias); 24 May 2019 19:58:48 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 27454 invoked by uid 89); 24 May 2019 19:58:48 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 24 May 2019 19:58:47 +0000 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4BF18859FF for ; Fri, 24 May 2019 19:58:46 +0000 (UTC) Received: from localhost (unused-10-15-17-196.yyz.redhat.com [10.15.17.196]) by smtp.corp.redhat.com (Postfix) with ESMTP id 21DA919C6A; Fri, 24 May 2019 19:58:46 +0000 (UTC) From: Sergio Durigan Junior To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 00/24] gdb::option framework, "print -OPT", other cmd options References: <20190522205327.2568-1-palves@redhat.com> Date: Fri, 24 May 2019 19:58:00 -0000 In-Reply-To: <20190522205327.2568-1-palves@redhat.com> (Pedro Alves's message of "Wed, 22 May 2019 21:53:03 +0100") Message-ID: <87lfyvoc96.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2019-05/txt/msg00572.txt.bz2 On Wednesday, May 22 2019, Pedro Alves wrote: > This all started a couple years ago with the idea that one reason > people sometimes complain about gdb's defaults, such as "set print > object" or "set print static-members" is that we don't have an easy > way to override the global print settings. [...] Thanks a lot for the patch series, I think it's a great feature to have! I have reviewed most of the patches so far, and pointed out some minor things I noticed here and there, but overall this seems good (albeit a bit complex to grok, like the gdb::option thing!). I'll continue reviewing and will let you know if I find more things, but I didn't want to block the progress of the feature, so I decided to send this "LGTM" now. Thanks, -- Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible http://sergiodj.net/