From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 115487 invoked by alias); 19 Mar 2019 20:06:18 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 115476 invoked by uid 89); 19 Mar 2019 20:06:18 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=HX-Languages-Length:541, f-lang.c, flangc, UD:f-lang.c X-HELO: gateway23.websitewelcome.com Received: from gateway23.websitewelcome.com (HELO gateway23.websitewelcome.com) (192.185.50.250) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 19 Mar 2019 20:06:17 +0000 Received: from cm14.websitewelcome.com (cm14.websitewelcome.com [100.42.49.7]) by gateway23.websitewelcome.com (Postfix) with ESMTP id 05B21FC56 for ; Tue, 19 Mar 2019 15:06:16 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 6L03hoS4D2qH76L04hFjFc; Tue, 19 Mar 2019 15:06:16 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=k9EzDwdw4RvLQA6palQvfyqJfAaOKkrtyCyFKC69BwM=; b=pQITA2tk51SsmNxxyoHpwLm4ME 9MjfmusqFmENC3Z/tjLf3zpcpHvxP6abparmPY9w2oSjMaj6sGk01/gjdfDMgR7JVQlrRP5s7l0fp ElktGoI/WWame/Vbp0uEPXaqY; Received: from 174-29-37-56.hlrn.qwest.net ([174.29.37.56]:48558 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1h6L03-004Cmm-P1; Tue, 19 Mar 2019 15:06:15 -0500 From: Tom Tromey To: Andrew Burgess Cc: gdb-patches@sourceware.org, Richard Bunt Subject: Re: [PATCH 3/8] gdb/fortran: Additional builtin procedures References: <12614ec36a52fca2dda675732df04310c2865b29.1552913183.git.andrew.burgess@embecosm.com> Date: Tue, 19 Mar 2019 20:06:00 -0000 In-Reply-To: <12614ec36a52fca2dda675732df04310c2865b29.1552913183.git.andrew.burgess@embecosm.com> (Andrew Burgess's message of "Mon, 18 Mar 2019 12:52:18 +0000") Message-ID: <87lg1avdc9.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-03/txt/msg00418.txt.bz2 >>>>> "Andrew" == Andrew Burgess writes: Andrew> * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_CEILING, Andrew> UNOP_FLOOR, BINOP_MODULE, BINOP_CMPLX. I think MODULE should be MODULO here. Andrew> + { "mod", BINOP_INTRINSIC, BINOP_MOD, false }, ... Andrew> + { "modulo", BINOP_INTRINSIC, BINOP_MODULO, false }, ... however, it seems confusing to have both BINOP_MOD and BINOP_MODULO. Maybe the new one could mention Fortran somehow? Tom