From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 106613 invoked by alias); 14 Feb 2019 15:45:49 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 97291 invoked by uid 89); 14 Feb 2019 15:45:43 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 14 Feb 2019 15:45:42 +0000 Received: from svr-orw-mbx-05.mgc.mentorg.com ([147.34.90.205]) by relay1.mentorg.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-SHA384:256) id 1guJCg-0001Wp-V0 from Thomas_Schwinge@mentor.com ; Thu, 14 Feb 2019 07:45:34 -0800 Received: from svr-orw-mbx-08.mgc.mentorg.com (147.34.90.208) by SVR-ORW-MBX-05.mgc.mentorg.com (147.34.90.205) with Microsoft SMTP Server (TLS) id 15.0.1320.4; Thu, 14 Feb 2019 07:45:32 -0800 Received: from tftp-cs (147.34.91.1) by svr-orw-mbx-08.mgc.mentorg.com (147.34.90.208) with Microsoft SMTP Server id 15.0.1320.4 via Frontend Transport; Thu, 14 Feb 2019 07:45:32 -0800 Received: by tftp-cs (Postfix, from userid 49978) id 2E7B0C2320; Thu, 14 Feb 2019 07:45:32 -0800 (PST) From: Thomas Schwinge To: CC: Pedro Alves , Tom Tromey Subject: Re: [PATCH] Use thread_info and inferior pointers more throughout In-Reply-To: References: <20180607180704.3991-1-palves@redhat.com> <87tvqeladc.fsf@tromey.com> <32766087-7cca-e149-65aa-f8e2df5ff23e@redhat.com> User-Agent: Notmuch/0.9-125-g4686d11 (http://notmuchmail.org) Emacs/25.2.2 (x86_64-pc-linux-gnu) Date: Thu, 14 Feb 2019 15:45:00 -0000 Message-ID: <87lg2iidbf.fsf@euler.schwinge.homeip.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-SW-Source: 2019-02/txt/msg00233.txt.bz2 --=-=-= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-length: 600 Hi! On Thu, 21 Jun 2018 17:20:54 +0100, Pedro Alves wrote: > >From 00431a78b28f913a9d5c912c49680e39cfd20847 Mon Sep 17 00:00:00 2001 > From: Pedro Alves > Date: Thu, 21 Jun 2018 17:09:31 +0100 > Subject: [PATCH] Use thread_info and inferior pointers more throughout > -void > -detach_inferior (int pid) > -{ > - detach_inferior (find_inferior_pid (pid)); > -} Pushed to master the attached commit c29ee8d45ec2113821c006a18cfedb9023ef9ce1 '[gdb, hurd] Repair build after "Use thread_info and inferior pointers more throughout"'. Gr=C3=BC=C3=9Fe Thomas --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename="0001-gdb-hurd-Repair-build-after-Use-thread_info-and-infe.patch" Content-length: 1930 >From c29ee8d45ec2113821c006a18cfedb9023ef9ce1 Mon Sep 17 00:00:00 2001 From: Thomas Schwinge Date: Tue, 24 Jul 2018 18:04:18 +0200 Subject: [PATCH] [gdb, hurd] Repair build after "Use thread_info and inferior pointers more throughout" ..., that is commit 00431a78b28f913a9d5c912c49680e39cfd20847 causing: [...]/gdb/gnu-nat.c: In member function 'virtual void gnu_nat_target::detach(inferior*, int)': [...]/gdb/gnu-nat.c:2284:23: error: invalid conversion from 'int' to 'inferior*' [-fpermissive] detach_inferior (pid); ^ In file included from [...]/gdb/gnu-nat.c:61:0: [...]/gdb/inferior.h:523:13: note: initializing argument 1 of 'void detach_inferior(inferior*)' extern void detach_inferior (inferior *inf); ^~~~~~~~~~~~~~~ Fixed by inlining the removed code. gdb/ * gnu-nat.c (gnu_nat_target::detach): Instead of 'detach_inferior (pid)' call 'detach_inferior (find_inferior_pid (pid))'. --- gdb/ChangeLog | 4 ++++ gdb/gnu-nat.c | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 2974d7275c..71c61bc909 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,9 @@ 2019-02-14 Thomas Schwinge + * gnu-nat.c (gnu_nat_target::detach): Instead of + 'detach_inferior (pid)' call + 'detach_inferior (find_inferior_pid (pid))'. + * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add 'nat/fork-inferior.o'. * gnu-nat.c: #include "nat/fork-inferior.h". diff --git a/gdb/gnu-nat.c b/gdb/gnu-nat.c index 5a47cb7d63..67cc95c68d 100644 --- a/gdb/gnu-nat.c +++ b/gdb/gnu-nat.c @@ -2279,7 +2279,7 @@ gnu_nat_target::detach (inferior *inf, int from_tty) inf_detach (gnu_current_inf); inferior_ptid = null_ptid; - detach_inferior (pid); + detach_inferior (find_inferior_pid (pid)); maybe_unpush_target (); } -- 2.19.2 --=-=-=--