From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 38767 invoked by alias); 14 Sep 2018 21:00:55 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 38719 invoked by uid 89); 14 Sep 2018 21:00:54 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,KAM_STOCKGEN,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=no version=3.3.2 spammy= X-HELO: gateway23.websitewelcome.com Received: from gateway23.websitewelcome.com (HELO gateway23.websitewelcome.com) (192.185.48.251) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 14 Sep 2018 21:00:52 +0000 Received: from cm13.websitewelcome.com (cm13.websitewelcome.com [100.42.49.6]) by gateway23.websitewelcome.com (Postfix) with ESMTP id 7A96929F52 for ; Fri, 14 Sep 2018 16:00:51 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 0vChgfcBD79N30vCngquaq; Fri, 14 Sep 2018 16:00:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=5/mXqkDnOaiGJtESCPJPT5lFs0XmAUFUAKNbeu++VDk=; b=O9L/jo2mkchiZoN0WAhREJvUMt wJM0YkZ/EKd4milSeImJBw0JG3zRyNXwwvkkmDl3XRjUz7dc2pMSIsXN7Kmt8/5g+KPlZEnl5cYqR fLiOhXYgSS0ivpz10SiIF11K3; Received: from 97-122-190-66.hlrn.qwest.net ([97.122.190.66]:45070 helo=pokyo) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1g0vCg-0049cv-Vz; Fri, 14 Sep 2018 16:00:39 -0500 From: Tom Tromey To: Richard Bunt Cc: gdb-patches@sourceware.org, nd@arm.com Subject: Re: [PATCH v3] Logical short circuiting with argument lists References: <833f15b2-48da-fe83-86c8-3c2bce46b01c@arm.com> Date: Fri, 14 Sep 2018 21:00:00 -0000 In-Reply-To: <833f15b2-48da-fe83-86c8-3c2bce46b01c@arm.com> (Richard Bunt's message of "Fri, 14 Sep 2018 09:08:58 +0100") Message-ID: <87lg833ibu.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-09/txt/msg00464.txt.bz2 >>>>> "Richard" == Richard Bunt writes: Richard> Version 3 addresses review comments: Richard> * Removed forward declaration of skip_undetermined_arglist. Richard> * Made definition of skip_undetermined_arglist static. Richard> * Added introductory comment to skip_undetermined_arglist. Richard> * Dropped (*pos)+=3 into the block. Richard> * Adjusted Tcl bracing. Richard> * Removed string splitting in the test case. Thanks again for the patch. Richard> + if (noside != EVAL_SKIP) Richard> + { Richard> + return evaluate_var_value (noside, exp->elts[pc + 1].block, var); Richard> + } The gdb style is no braces if there's just a single line. Richard> + else Richard> + { Richard> + /* Return a dummy value of the correct type when skipping, so Richard> + that parent functions know what is to be skipped. */ Richard> + return allocate_value (SYMBOL_TYPE (var)); ... compared to here, where braces are mandatory. This patch is ok with that first set of braces removed. (You don't have to re-send it.) thanks, Tom