public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Jan Vrany <jan.vrany@fit.cvut.cz>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix various tests to use -no-pie linker flag when needed
Date: Fri, 07 Sep 2018 20:43:00 -0000	[thread overview]
Message-ID: <87lg8dvy0o.fsf@tromey.com> (raw)
In-Reply-To: <20180828193643.15530-1-jan.vrany@fit.cvut.cz> (Jan Vrany's	message of "Tue, 28 Aug 2018 20:36:43 +0100")

>>>>> "Jan" == Jan Vrany <jan.vrany@fit.cvut.cz> writes:

Jan> Various test use test code written in i385 / x86_64 assembly that cannot
Jan> be used to create PIE executables. Therefore compilation of test programs
Jan> failed on systems where the compiler default is to create PIE executable.

Jan> To fix this, force -no-pie linker flag.

I guess you're on an OS that enables PIE by default?

These tests don't seem to be linux- or gcc-specific.
Do you know how universal -no-pie is?  My worry is that this would fix
the test for some people but break it for others.

Tom

  reply	other threads:[~2018-09-07 20:43 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-28 19:37 Jan Vrany
2018-09-07 20:43 ` Tom Tromey [this message]
2018-09-07 22:18   ` Simon Marchi
2018-10-14  9:59     ` Jan Vrany
2018-10-16 22:18       ` Simon Marchi
2018-10-17 13:55         ` Tom Tromey
2018-10-17 14:56           ` [PATCH v2] " Jan Vrany
2018-10-17 15:12             ` [PATCH v3] " Jan Vrany
2018-10-17 15:44               ` Simon Marchi
2018-10-17 15:53                 ` Simon Marchi
2018-10-17 19:33                   ` Jan Vrany
2018-12-13 15:21                   ` [PATCH] " Jan Vrany
2018-12-13 17:13                     ` Simon Marchi
2018-12-21 20:56                       ` Simon Marchi
2018-10-17 15:47         ` Pedro Alves
2018-10-17 15:51           ` Simon Marchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lg8dvy0o.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=gdb-patches@sourceware.org \
    --cc=jan.vrany@fit.cvut.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).