From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 50309 invoked by alias); 31 Aug 2018 16:03:50 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 50300 invoked by uid 89); 31 Aug 2018 16:03:49 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=automate, alright, Hx-languages-length:1868, updategnulibsh X-HELO: mx1.redhat.com Received: from mx3-rdu2.redhat.com (HELO mx1.redhat.com) (66.187.233.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 31 Aug 2018 16:03:48 +0000 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 33D1F4021710; Fri, 31 Aug 2018 16:03:47 +0000 (UTC) Received: from localhost (unused-10-15-17-196.yyz.redhat.com [10.15.17.196]) by smtp.corp.redhat.com (Postfix) with ESMTP id 180BC202706C; Fri, 31 Aug 2018 16:03:47 +0000 (UTC) From: Sergio Durigan Junior To: Pedro Alves Cc: Simon Marchi , GDB Patches , Tom Tromey Subject: Re: [PATCH] Update gnulib/Makefile.in:aclocal_m4_deps References: <20180830155724.20000-1-sergiodj@redhat.com> <72e6edf3ddf2c9994c5e5d3ebfbfb171@polymtl.ca> <87bm9jiq05.fsf@redhat.com> Date: Fri, 31 Aug 2018 16:03:00 -0000 In-Reply-To: (Pedro Alves's message of "Fri, 31 Aug 2018 12:21:30 +0100") Message-ID: <87lg8mh6al.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2018-08/txt/msg00876.txt.bz2 On Friday, August 31 2018, Pedro Alves wrote: > On 08/30/2018 09:00 PM, Sergio Durigan Junior wrote: >> On Thursday, August 30 2018, Simon Marchi wrote: >> >>> On 2018-08-30 11:57, Sergio Durigan Junior wrote: > >>>> $(srcdir)/aclocal.m4: @MAINTAINER_MODE_TRUE@ $(aclocal_m4_deps) >>>> cd $(srcdir) && $(ACLOCAL) $(ACLOCAL_AMFLAGS) >>> >>> This looks good to me, the set of m4 files listed here matches the >>> list of actual m4 files in import/m4. Follow-up question, could we >>> use $(wildcard ...) instead of listing them by hand? >> >> Yeah, I think that could work. That's basically what I did to generate >> this list: "ls *.m4". If you want, I can edit the patch and make it use >> $(wildcard) before pushing it. >> > > Really not sure that's a good idea. We don't use $wildcard for listing .c files > either, for example, and I think for good reason. It makes the set of files to build > dependent of what you happen to have or not have locally, instead of determined > statically. That in general affects development, changing git branches, etc. > Consider that GDB even links successfully if you miss including/linking some .c file > in the build, given the _initialize_foo registration mechanism. Hm, alright, that's a good point. > Maybe not so much an issue with the m4 files, but I'd think a more > principle approach to automate this would be to make the > update-gnulib.sh script generate/update a Makefile fragment file that > contained the aclocal_m4_deps m4 files list, check that file into the > tree, and then gdb/gnulib/Makefile.in would source/include that > fragment file. Yeah, that works as well. I'll work on a patch and submit it soon. Thanks, -- Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible http://sergiodj.net/